* [2.5] double free in ext2?
@ 2003-03-07 10:06 Oleg Drokin
2003-03-07 10:11 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Drokin @ 2003-03-07 10:06 UTC (permalink / raw)
To: linux-kernel, akpm
Hello!
I am playing with smatch and while testing my improved version of
unfree.pl, I seems to have found a double free condition in ext2:
fs/ext2/super.c::ext2_fill_super() (I am looking at yesterday's 2.5 snapshot)
in line 784 we do kfree(sbi->s_group_desc); (then print "EXT2-fs: unable to read group descriptors\n")
and go to failed_mount_group_desc, which reads (from line 821):
failed_mount_group_desc:
kfree(sbi->s_group_desc);
2.4 is not affected.
Bye,
Oleg
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.5] double free in ext2?
2003-03-07 10:06 [2.5] double free in ext2? Oleg Drokin
@ 2003-03-07 10:11 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2003-03-07 10:11 UTC (permalink / raw)
To: Oleg Drokin; +Cc: linux-kernel
Oleg Drokin <green@namesys.com> wrote:
>
> Hello!
>
> I am playing with smatch and while testing my improved version of
> unfree.pl, I seems to have found a double free condition in ext2:
>
> fs/ext2/super.c::ext2_fill_super() (I am looking at yesterday's 2.5 snapshot)
>
> in line 784 we do kfree(sbi->s_group_desc); (then print "EXT2-fs: unable to read group descriptors\n")
> and go to failed_mount_group_desc, which reads (from line 821):
> failed_mount_group_desc:
> kfree(sbi->s_group_desc);
>
yes, bug. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-03-07 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-07 10:06 [2.5] double free in ext2? Oleg Drokin
2003-03-07 10:11 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.