* [2.4] Memleak on error exit path in Aironet 4500 Pcmcia driver
@ 2003-03-12 19:15 Oleg Drokin
0 siblings, 0 replies; only message in thread
From: Oleg Drokin @ 2003-03-12 19:15 UTC (permalink / raw)
To: alan, linux-kernel, elmer
Hello!
There is a memleak on OOM in Aironet 4500 Pcmcia driver,
trivial to fix. See the patch.
Found with help of smatch + enhanced unfree script.
Bye,
Oleg
===== drivers/net/pcmcia/aironet4500_cs.c 1.8 vs edited =====
--- 1.8/drivers/net/pcmcia/aironet4500_cs.c Wed Aug 7 22:27:37 2002
+++ edited/drivers/net/pcmcia/aironet4500_cs.c Wed Mar 12 22:13:20 2003
@@ -282,7 +282,13 @@
};
memset(dev,0,sizeof(struct net_device));
dev->priv = kmalloc(sizeof(struct awc_private), GFP_KERNEL);
- if (!dev->priv ) {printk(KERN_CRIT "out of mem on dev priv alloc \n"); return NULL;};
+ if (!dev->priv ) {
+ printk(KERN_CRIT "out of mem on dev priv alloc \n");
+ kfree(dev);
+ kfree(link->dev);
+ kfree(link);
+ return NULL;
+ }
memset(dev->priv,0,sizeof(struct awc_private));
// link->dev->minor = dev->minor;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-03-12 19:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-12 19:15 [2.4] Memleak on error exit path in Aironet 4500 Pcmcia driver Oleg Drokin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.