From: Jens Axboe <axboe@suse.de>
To: Arjan van de Ven <arjanv@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Randy.Dunlap" <randy.dunlap@verizon.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@transmeta.com>,
leo@netlabs.net
Subject: Re: [PATCH] reduce stack in cdrom/optcd.c
Date: Tue, 25 Mar 2003 19:29:16 +0100 [thread overview]
Message-ID: <20030325182916.GI30908@suse.de> (raw)
In-Reply-To: <1048364399.1708.4.camel@laptop.fenrus.com>
On Sat, Mar 22 2003, Arjan van de Ven wrote:
> On Sat, 2003-03-22 at 21:43, Alan Cox wrote:
> > On Sat, 2003-03-22 at 06:51, Randy.Dunlap wrote:
> > > Hi,
> > >
> > > This reduces stack usage in drivers/cdrom/optcd.c by
> > > dynamically allocating a large (> 2 KB) buffer.
> > >
> > > Patch is to 2.5.65. Please apply.
> >
> > This loosk broken. You are using GFP_KERNEL memory allocations on the
> > read path of a block device. What happens if the allocation fails
> > because we need memory
>
> it's unlikely that you have your swap on the cdrom ;)
your swap device could still be plugged behind your cdrom.
--
Jens Axboe
next prev parent reply other threads:[~2003-03-25 18:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-22 6:51 [PATCH] reduce stack in cdrom/optcd.c Randy.Dunlap
2003-03-22 20:43 ` Alan Cox
2003-03-22 20:19 ` Arjan van de Ven
2003-03-25 18:29 ` Jens Axboe [this message]
2003-03-25 18:43 ` Randy.Dunlap
-- strict thread matches above, loose matches on Subject: below --
2003-03-26 20:12 Randy.Dunlap
2003-03-27 6:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030325182916.GI30908@suse.de \
--to=axboe@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjanv@redhat.com \
--cc=leo@netlabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@verizon.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.