From: Jens Axboe <axboe@suse.de>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reduce stack in cdrom/optcd.c
Date: Thu, 27 Mar 2003 07:54:17 +0100 [thread overview]
Message-ID: <20030327065417.GM30908@suse.de> (raw)
In-Reply-To: <20030326121250.56b4d62a.rddunlap@osdl.org>
On Wed, Mar 26 2003, Randy.Dunlap wrote:
>
> (resend; was lost last night)
>
>
> > From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> >
> > On Sat, 2003-03-22 at 06:51, Randy.Dunlap wrote:
> > > Hi,
> > >
> > > This reduces stack usage in drivers/cdrom/optcd.c by
> > > dynamically allocating a large (> 2 KB) buffer.
> > >
> > > Patch is to 2.5.65. Please apply.
> >
> > This loosk broken. You are using GFP_KERNEL memory allocations on the
> > read path of a block device. What happens if the allocation fails
> > because we need memory
> >
> > Surely that buffer needs to be allocated once at open and freed on close
> > ?
> > --
>
>
> Alan, Jens, anybody else-
>
> Does this pass?
Yes, looks much better.
--
Jens Axboe
next prev parent reply other threads:[~2003-03-27 6:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-26 20:12 [PATCH] reduce stack in cdrom/optcd.c Randy.Dunlap
2003-03-27 6:54 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-03-22 6:51 Randy.Dunlap
2003-03-22 20:43 ` Alan Cox
2003-03-22 20:19 ` Arjan van de Ven
2003-03-25 18:29 ` Jens Axboe
2003-03-25 18:43 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030327065417.GM30908@suse.de \
--to=axboe@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.