All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: Christoph Hellwig <hch@infradead.org>,
	Jan Dittmer <j.dittmer@portrix.net>,
	azarah@gentoo.org, KML <linux-kernel@vger.kernel.org>,
	Dominik Brodowski <linux@brodo.de>,
	sensors@stimpy.netroedge.com
Subject: w83781d i2c driver updated for 2.5.66 (without sysfs support)
Date: Thu, 19 May 2005 06:23:51 +0000	[thread overview]
Message-ID: <20030326212318.GA26886@kroah.com> (raw)
In-Reply-To: <20030326204343.A22053@infradead.org>

On Wed, Mar 26, 2003 at 08:43:43PM +0000, Christoph Hellwig wrote:
> On Wed, Mar 26, 2003 at 12:26:23PM -0800, Greg KH wrote:
> > We should really split these multivalue files up into individual files,
> > as sysfs is for single value files.  Makes parsing easier too.
> > 
> > Here's a patch for the lm75.c driver that does this.  As we are going to
> > need a "generic" read and write for the "real" values that the i2c
> > drivers use, I added these files to the i2c-proc.c file.
> 
> i2c-proc.c is the wrong place.  Please add a i2c-sensor.c file with
> helper code for hardware sensors driver (i2c_detect should move over to
> there from i2c-proc.c aswell)

Oh, I agree.  I just threw it there as I was matching up with other
functions already in that file.  Eventually i2c-proc.c should be
deleted, as all of the proc stuff will be gone.  I like the idea of
i2c-sensor.c for the remaining i2c_detect() function.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@infradead.org>,
	Jan Dittmer <j.dittmer@portrix.net>,
	azarah@gentoo.org, KML <linux-kernel@vger.kernel.org>,
	Dominik Brodowski <linux@brodo.de>,
	sensors@stimpy.netroedge.com
Subject: Re: w83781d i2c driver updated for 2.5.66 (without sysfs support)
Date: Wed, 26 Mar 2003 13:23:18 -0800	[thread overview]
Message-ID: <20030326212318.GA26886@kroah.com> (raw)
In-Reply-To: <20030326204343.A22053@infradead.org>

On Wed, Mar 26, 2003 at 08:43:43PM +0000, Christoph Hellwig wrote:
> On Wed, Mar 26, 2003 at 12:26:23PM -0800, Greg KH wrote:
> > We should really split these multivalue files up into individual files,
> > as sysfs is for single value files.  Makes parsing easier too.
> > 
> > Here's a patch for the lm75.c driver that does this.  As we are going to
> > need a "generic" read and write for the "real" values that the i2c
> > drivers use, I added these files to the i2c-proc.c file.
> 
> i2c-proc.c is the wrong place.  Please add a i2c-sensor.c file with
> helper code for hardware sensors driver (i2c_detect should move over to
> there from i2c-proc.c aswell)

Oh, I agree.  I just threw it there as I was matching up with other
functions already in that file.  Eventually i2c-proc.c should be
deleted, as all of the proc stuff will be gone.  I like the idea of
i2c-sensor.c for the remaining i2c_detect() function.

thanks,

greg k-h

  reply	other threads:[~2005-05-19  6:23 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-25  8:53 i2c driver changes for 2.5.66; adding w83781d support Martin Schlemmer
2003-03-25 17:56 ` Greg KH
2003-03-26 19:04   ` w83781d i2c driver updated for 2.5.66 (without sysfs support) Martin Schlemmer
2005-05-19  6:23     ` Martin Schlemmer
2003-03-26 19:40     ` Jan Dittmer
2005-05-19  6:23       ` Jan Dittmer
2003-03-26 19:54       ` Martin Schlemmer
2005-05-19  6:23         ` Martin Schlemmer
2003-03-26 20:26       ` Greg KH
2005-05-19  6:23         ` Greg KH
2003-03-26 20:43         ` Christoph Hellwig
2005-05-19  6:23           ` Christoph Hellwig
2003-03-26 21:23           ` Greg KH [this message]
2005-05-19  6:23             ` Greg KH
2003-03-26 22:26         ` Mark Studebaker
2005-05-19  6:23           ` Mark Studebaker
2003-03-26 22:52           ` lm sensors sysfs file structure Greg KH
2005-05-19  6:23             ` Greg KH
2003-03-27 10:46             ` Jan Dittmer
2005-05-19  6:23               ` Jan Dittmer
2003-03-27 10:50               ` Martin Schlemmer
2005-05-19  6:23                 ` Martin Schlemmer
2003-03-27 12:27                 ` Jan Dittmer
2005-05-19  6:23                   ` Jan Dittmer
2003-03-27 12:33                   ` Martin Schlemmer
2005-05-19  6:23                     ` Martin Schlemmer
2003-03-27 13:05                     ` Jan Dittmer
2005-05-19  6:23                       ` Jan Dittmer
2003-03-27 13:31                       ` Jean Delvare
2005-05-19  6:23                         ` Jean Delvare
2003-03-27 17:16                         ` Mark M. Hoffman
2005-05-19  6:23                           ` Mark M. Hoffman
2003-03-27 17:25               ` Greg KH
2005-05-19  6:23                 ` Greg KH
2003-03-27 18:06                 ` Jan Dittmer
2005-05-19  6:23                   ` Jan Dittmer
2003-03-27 18:13                   ` Greg KH
2005-05-19  6:23                     ` Greg KH
2003-03-30 19:23                 ` Pavel Machek
2005-05-19  6:23                   ` Pavel Machek
2003-04-01  6:44                   ` Greg KH
2005-05-19  6:23                     ` Greg KH
2003-04-01 20:22                     ` Pavel Machek
2005-05-19  6:23                       ` Pavel Machek
2003-04-01 23:27                     ` Dave Jones
2005-05-19  6:23                       ` Dave Jones
2003-04-03  0:28                       ` Greg KH
2005-05-19  6:23                         ` Greg KH
2003-04-03 10:49                         ` Dave Jones
2005-05-19  6:23                           ` Dave Jones
2003-04-03 18:43                           ` Dominik Brodowski
2005-05-19  6:23                             ` Dominik Brodowski
2003-03-27 18:40             ` Jan Dittmer
2005-05-19  6:23               ` Jan Dittmer
2003-03-27 18:52               ` Greg KH
2005-05-19  6:23                 ` Greg KH
2003-03-27 18:17                 ` Patrick Mochel
2005-05-19  6:23                   ` Patrick Mochel
2003-03-27 18:57                 ` Jan Dittmer
2003-03-27 19:15                 ` Martin Schlemmer
2005-05-19  6:23                   ` Martin Schlemmer
2003-03-27 19:25                   ` Greg KH
2005-05-19  6:23                     ` Greg KH
2003-03-27 19:42             ` Greg KH
2005-05-19  6:23               ` Greg KH
2003-03-27 20:32               ` Jan Dittmer
2005-05-19  6:23                 ` Jan Dittmer
2003-03-27 21:53                 ` Greg KH
2005-05-19  6:23                   ` Greg KH
2003-03-27 22:23                   ` Mark M. Hoffman
2005-05-19  6:23                     ` Mark M. Hoffman
2003-03-28  6:05                   ` Martin Schlemmer
2005-05-19  6:23                     ` Martin Schlemmer
2003-03-28 18:34             ` Pavel Machek
2005-05-19  6:23               ` Pavel Machek
2003-03-26 20:29     ` w83781d i2c driver updated for 2.5.66 (without sysfs support) Greg KH
2005-05-19  6:23       ` Greg KH
2003-03-26 23:34       ` Martin Schlemmer
2005-05-19  6:23         ` Martin Schlemmer
2003-03-26 23:46         ` Greg KH
2005-05-19  6:23           ` Greg KH
2003-03-30 12:47           ` [PATCH-2.5] w83781d i2c driver updated for 2.5.66-bk4 (with sysfs support, empty tree) Martin Schlemmer
2005-05-19  6:23             ` [PATCH-2.5] w83781d i2c driver updated for 2.5.66-bk4 (with sysfs Martin Schlemmer
2003-04-02 22:22             ` [PATCH-2.5] w83781d i2c driver updated for 2.5.66-bk4 (with sysfs support, empty tree) Greg KH
2005-05-19  6:23               ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2003-04-03 21:19 lm sensors sysfs file structure Grover, Andrew
2005-05-19  6:23 ` Grover, Andrew
2003-04-14 15:16 ` Patrick Mochel
2005-05-19  6:23   ` Patrick Mochel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030326212318.GA26886@kroah.com \
    --to=greg@kroah.com \
    --cc=azarah@gentoo.org \
    --cc=hch@infradead.org \
    --cc=j.dittmer@portrix.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@brodo.de \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.