From: Dave Jones <davej@codemonkey.org.uk>
To: Andrew Morton <akpm@digeo.com>
Cc: Linus Torvalds <torvalds@transmeta.com>, jjs <jjs@tmsusa.com>,
"Grover, Andrew" <andrew.grover@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] acpi compile fix
Date: Fri, 4 Apr 2003 13:18:12 +0100 [thread overview]
Message-ID: <20030404121812.GA23352@suse.de> (raw)
In-Reply-To: <20030403130505.199294c7.akpm@digeo.com>
On Thu, Apr 03, 2003 at 01:05:05PM -0800, Andrew Morton wrote:
> diff -puN drivers/acpi/osl.c~acpi-spinlock-casts drivers/acpi/osl.c
> --- 25/drivers/acpi/osl.c~acpi-spinlock-casts Thu Apr 3 13:00:54 2003
> +++ 25-akpm/drivers/acpi/osl.c Thu Apr 3 13:01:25 2003
> @@ -736,7 +736,7 @@ acpi_os_acquire_lock (
> if (flags & ACPI_NOT_ISR)
> ACPI_DISABLE_IRQS();
>
> - spin_lock(handle);
> + spin_lock((spinlock_t *)handle);
Is there a reason these functions can't just have their arguments
changed to take a spinlock_t* instead of an acpi_handle ?
That cast looks really fugly IMO.
Dave
next prev parent reply other threads:[~2003-04-04 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-03 21:05 [patch] acpi compile fix Andrew Morton
2003-04-04 6:48 ` J Sloan
2003-04-04 12:18 ` Dave Jones [this message]
2003-04-04 19:57 ` Andrew Morton
2003-04-04 20:27 ` Dave Jones
-- strict thread matches above, loose matches on Subject: below --
2003-04-04 21:41 Grover, Andrew
2002-07-26 18:42 [PATCH] ACPI " Andy Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030404121812.GA23352@suse.de \
--to=davej@codemonkey.org.uk \
--cc=akpm@digeo.com \
--cc=andrew.grover@intel.com \
--cc=jjs@tmsusa.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.