From: Dave Jones <davej@codemonkey.org.uk>
To: Andrew Morton <akpm@digeo.com>
Cc: torvalds@transmeta.com, jjs@tmsusa.com, andrew.grover@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [patch] acpi compile fix
Date: Fri, 4 Apr 2003 21:27:44 +0100 [thread overview]
Message-ID: <20030404202744.GG29047@suse.de> (raw)
In-Reply-To: <20030404115756.66d87211.akpm@digeo.com>
On Fri, Apr 04, 2003 at 11:57:56AM -0800, Andrew Morton wrote:
> I think acpi_handle_t is "an opaque type specific to the OS on which the APCI
> code happens to be running".
I don't see how putting a spinlock_t cast in the code is any more
portable between OS's than spinlock_t as a function parameter.
> If the above guesses (I'd prefer not to look) are correct then
> struct acpi_handle_t {
> spinlock_t lock;
> };
>
> would make a ton more sense.
That would solve the portability argument in my eyes if that is
indeed the case here. It's still ugly, but it at least kills
the problem in a slightly more tasteful way.
Dave
next prev parent reply other threads:[~2003-04-04 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-03 21:05 [patch] acpi compile fix Andrew Morton
2003-04-04 6:48 ` J Sloan
2003-04-04 12:18 ` Dave Jones
2003-04-04 19:57 ` Andrew Morton
2003-04-04 20:27 ` Dave Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-04-04 21:41 Grover, Andrew
2002-07-26 18:42 [PATCH] ACPI " Andy Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030404202744.GG29047@suse.de \
--to=davej@codemonkey.org.uk \
--cc=akpm@digeo.com \
--cc=andrew.grover@intel.com \
--cc=jjs@tmsusa.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.