From: greg@kroah.com (Greg KH)
To: Martin Schlemmer <azarah@gentoo.org>
Cc: KML <linux-kernel@vger.kernel.org>, sensors@Stimpy.netroedge.com
Subject: [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs
Date: Thu, 19 May 2005 06:23:52 +0000 [thread overview]
Message-ID: <20030409074124.GA9813@kroah.com> (raw)
In-Reply-To: <1049869101.2754.31.camel@workshop.saharact.lan>
On Wed, Apr 09, 2003 at 08:18:21AM +0200, Martin Schlemmer wrote:
> On Wed, 2003-04-09 at 00:04, Greg KH wrote:
>
> > Oh, I'm getting the following warning when building the driver, want to
> > look into this?
> >
> > drivers/i2c/chips/w83781d.c: In function `store_fan_div_reg':
> > drivers/i2c/chips/w83781d.c:715: warning: `old3' might be used uninitialized in this function
> >
>
> It is because old3 is only referenced if:
>
> ((data->type != w83781d) && data->type != as99127f)
>
> as those two chips don't have extended divisor bits ...
>
> It is however set in the first occurrence:
>
> ---------------------------------------------------------------------
> /* w83781d and as99127f don't have extended divisor bits */
> if ((data->type != w83781d) && data->type != as99127f) {
> old3 = w83781d_read_value(client, W83781D_REG_VBAT);
> }
> ---------------------------------------------------------------------
>
> and thus is rather gcc being brain dead for not being able to figure
> old3 is only used within a if block like that.
>
> I was not sure about style policy in a case like this, so I left it as
> is, it should however be possible to 'fix' it with:
Thanks, I've applied this.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Martin Schlemmer <azarah@gentoo.org>
Cc: KML <linux-kernel@vger.kernel.org>, sensors@Stimpy.netroedge.com
Subject: Re: [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs
Date: Wed, 9 Apr 2003 00:41:24 -0700 [thread overview]
Message-ID: <20030409074124.GA9813@kroah.com> (raw)
In-Reply-To: <1049869101.2754.31.camel@workshop.saharact.lan>
On Wed, Apr 09, 2003 at 08:18:21AM +0200, Martin Schlemmer wrote:
> On Wed, 2003-04-09 at 00:04, Greg KH wrote:
>
> > Oh, I'm getting the following warning when building the driver, want to
> > look into this?
> >
> > drivers/i2c/chips/w83781d.c: In function `store_fan_div_reg':
> > drivers/i2c/chips/w83781d.c:715: warning: `old3' might be used uninitialized in this function
> >
>
> It is because old3 is only referenced if:
>
> ((data->type != w83781d) && data->type != as99127f)
>
> as those two chips don't have extended divisor bits ...
>
> It is however set in the first occurrence:
>
> ---------------------------------------------------------------------
> /* w83781d and as99127f don't have extended divisor bits */
> if ((data->type != w83781d) && data->type != as99127f) {
> old3 = w83781d_read_value(client, W83781D_REG_VBAT);
> }
> ---------------------------------------------------------------------
>
> and thus is rather gcc being brain dead for not being able to figure
> old3 is only used within a if block like that.
>
> I was not sure about style policy in a case like this, so I left it as
> is, it should however be possible to 'fix' it with:
Thanks, I've applied this.
greg k-h
next prev parent reply other threads:[~2005-05-19 6:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-07 21:16 [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs Martin Schlemmer
2005-05-19 6:23 ` Martin Schlemmer
2003-04-07 21:54 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-04-08 4:11 ` Martin Schlemmer
2005-05-19 6:23 ` [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in Martin Schlemmer
2003-04-08 22:04 ` [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs Greg KH
2005-05-19 6:23 ` Greg KH
2003-04-09 6:18 ` Martin Schlemmer
2005-05-19 6:23 ` [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in Martin Schlemmer
2003-04-09 7:41 ` Greg KH [this message]
2005-05-19 6:23 ` [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in sysfs Greg KH
2003-04-08 22:11 ` Martin Schlemmer
2005-05-19 6:23 ` [PATCH-2.5] Fix w83781d sensor to use Milli-Volt for in_* in Martin Schlemmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030409074124.GA9813@kroah.com \
--to=greg@kroah.com \
--cc=azarah@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.