From: Rudmer van Dijk <rudmer@legolas.dynup.net>
To: Bill Huey (Hui) <billh@gnuppy.monkey.org>,
Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.5.67-mm3
Date: Mon, 14 Apr 2003 17:13:05 +0200 [thread overview]
Message-ID: <200304141707.45601@gandalf> (raw)
In-Reply-To: <20030414110326.GA19003@gnuppy.monkey.org>
On Monday 14 April 2003 13:03, Bill Huey (Hui) wrote:
> On Mon, Apr 14, 2003 at 01:53:13AM -0700, Andrew Morton wrote:
> > A bunch of new fixes, and a framebuffer update. This should work a bit
> > better than -mm2.
>
> make -f scripts/Makefile.build obj=arch/i386/boot arch/i386/boot/bzImage
> ld -m elf_i386 -Ttext 0x0 -s --oformat binary -e begtext
> arch/i386/boot/setup.o -o arch/i386/boot/setup
> arch/i386/boot/setup.o(.text+0x9a4): In function `video':
> /tmp/ccyhvWWu.s:2925: undefined reference to `store_edid'
> make[1]: *** [arch/i386/boot/setup] Error 1
> make: *** [bzImage] Error 2
>
> ---------------------------------------
got this also.
store_edid is only used when CONFIG_VIDEO_SELECT is set but the call to it is
outside the #ifdef...
this patch fixes it. Maybe it is better to move the call to store_edid up
inside the already avilable #ifdef but I'm not sure if that is possible
Rudmer
--- linux-2.5.67-mm3/arch/i386/boot/video.S.orig 2003-04-14
17:07:24.000000000 +0200
+++ linux-2.5.67-mm3/arch/i386/boot/video.S 2003-04-14 17:03:08.000000000
+0200
@@ -135,7 +135,9 @@
#endif /* CONFIG_VIDEO_RETAIN */
#endif /* CONFIG_VIDEO_SELECT */
call mode_params # Store mode parameters
+#ifdef CONFIG_VIDEO_SELECT
call store_edid
+#endif /* CONFIG_VIDEO_SELECT */
popw %ds # Restore original DS
ret
WARNING: multiple messages have this Message-ID (diff)
From: Rudmer van Dijk <rudmer@legolas.dynup.net>
To: "Bill Huey (Hui)" <billh@gnuppy.monkey.org>,
Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.5.67-mm3
Date: Mon, 14 Apr 2003 17:13:05 +0200 [thread overview]
Message-ID: <200304141707.45601@gandalf> (raw)
In-Reply-To: <20030414110326.GA19003@gnuppy.monkey.org>
On Monday 14 April 2003 13:03, Bill Huey (Hui) wrote:
> On Mon, Apr 14, 2003 at 01:53:13AM -0700, Andrew Morton wrote:
> > A bunch of new fixes, and a framebuffer update. This should work a bit
> > better than -mm2.
>
> make -f scripts/Makefile.build obj=arch/i386/boot arch/i386/boot/bzImage
> ld -m elf_i386 -Ttext 0x0 -s --oformat binary -e begtext
> arch/i386/boot/setup.o -o arch/i386/boot/setup
> arch/i386/boot/setup.o(.text+0x9a4): In function `video':
> /tmp/ccyhvWWu.s:2925: undefined reference to `store_edid'
> make[1]: *** [arch/i386/boot/setup] Error 1
> make: *** [bzImage] Error 2
>
> ---------------------------------------
got this also.
store_edid is only used when CONFIG_VIDEO_SELECT is set but the call to it is
outside the #ifdef...
this patch fixes it. Maybe it is better to move the call to store_edid up
inside the already avilable #ifdef but I'm not sure if that is possible
Rudmer
--- linux-2.5.67-mm3/arch/i386/boot/video.S.orig 2003-04-14
17:07:24.000000000 +0200
+++ linux-2.5.67-mm3/arch/i386/boot/video.S 2003-04-14 17:03:08.000000000
+0200
@@ -135,7 +135,9 @@
#endif /* CONFIG_VIDEO_RETAIN */
#endif /* CONFIG_VIDEO_SELECT */
call mode_params # Store mode parameters
+#ifdef CONFIG_VIDEO_SELECT
call store_edid
+#endif /* CONFIG_VIDEO_SELECT */
popw %ds # Restore original DS
ret
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2003-04-14 15:01 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-14 8:53 2.5.67-mm3 Andrew Morton
2003-04-14 8:53 ` 2.5.67-mm3 Andrew Morton
2003-04-14 11:03 ` 2.5.67-mm3 Bill Huey
2003-04-14 11:03 ` 2.5.67-mm3 Bill Huey
2003-04-14 15:13 ` Rudmer van Dijk [this message]
2003-04-14 15:13 ` 2.5.67-mm3 Rudmer van Dijk
2003-04-15 1:03 ` 2.5.67-mm3 Bill Huey
2003-04-15 1:03 ` 2.5.67-mm3 Bill Huey
2003-04-15 1:13 ` 2.5.67-mm3 Andrew Morton
2003-04-15 1:13 ` 2.5.67-mm3 Andrew Morton
2003-04-15 1:34 ` 2.5.67-mm3 Bill Huey
2003-04-15 1:34 ` 2.5.67-mm3 Bill Huey
2003-04-15 9:38 ` 2.5.67-mm3 Rudmer van Dijk
2003-04-15 9:38 ` 2.5.67-mm3 Rudmer van Dijk
2003-04-15 2:00 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 2:00 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 4:17 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 4:17 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 4:31 ` 2.5.67-mm3 Andrew Morton
2003-04-15 4:31 ` 2.5.67-mm3 Andrew Morton
2003-04-15 4:39 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 4:39 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 4:55 ` 2.5.67-mm3 Andrew Morton
2003-04-15 4:55 ` 2.5.67-mm3 Andrew Morton
2003-04-15 5:15 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 5:15 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 5:35 ` 2.5.67-mm3 Andrew Morton
2003-04-15 5:35 ` 2.5.67-mm3 Andrew Morton
2003-04-15 6:09 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 6:09 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 6:10 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 6:10 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 5:52 ` 2.5.67-mm3 Antonio Vargas
2003-04-15 5:52 ` 2.5.67-mm3 Antonio Vargas
2003-04-15 5:52 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 5:52 ` 2.5.67-mm3 William Lee Irwin III
2003-04-15 15:09 ` 2.5.67-mm3 Antonio Vargas
2003-04-15 15:09 ` 2.5.67-mm3 Antonio Vargas
2003-04-16 2:21 ` 2.5.67-mm3 William Lee Irwin III
2003-04-16 2:21 ` 2.5.67-mm3 William Lee Irwin III
2003-04-16 2:40 ` 2.5.67-mm3 William Lee Irwin III
2003-04-16 2:40 ` 2.5.67-mm3 William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200304141707.45601@gandalf \
--to=rudmer@legolas.dynup.net \
--cc=akpm@digeo.com \
--cc=billh@gnuppy.monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.