From: Benjamin LaHaise <bcrl@redhat.com>
To: Suparna Bhattacharya <suparna@in.ibm.com>
Cc: akpm@digeo.com, linux-kernel@vger.kernel.org,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org
Subject: Re: Filesystem AIO read-write patches
Date: Thu, 24 Apr 2003 09:13:12 -0400 [thread overview]
Message-ID: <20030424091312.E9036@redhat.com> (raw)
In-Reply-To: <20030424102221.A2166@in.ibm.com>; from suparna@in.ibm.com on Thu, Apr 24, 2003 at 10:22:22AM +0530
On Thu, Apr 24, 2003 at 10:22:22AM +0530, Suparna Bhattacharya wrote:
> The task->io_wait field reflects the wait context in which
> a task is executing its i/o operations. For synchronous i/o
> task->io_wait is NULL, and the wait context is local on
> stack; for threads doing io submits or retries on behalf
> of async i/o callers, tsk->io_wait is the wait queue
> function entry to be notified on completion of a condition
> required for i/o to progress.
This is seriously wrong. Changing the behaviour of functions to depend on
a hidden parameter is bound to lead to coding errors. It is far better to
make the parameter explicite rather than implicite.
-ben
next prev parent reply other threads:[~2003-04-24 13:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-24 4:52 Filesystem AIO read-write patches Suparna Bhattacharya
2003-04-24 4:52 ` Suparna Bhattacharya
2003-04-24 5:00 ` [PATCH 1/7] Filesystem AIO rdwr - aio retry core changes Suparna Bhattacharya
2003-04-24 5:00 ` Suparna Bhattacharya
2003-04-24 5:04 ` [PATCH 2/7] Filesystem AIO rdwr - aio read Suparna Bhattacharya
2003-04-24 5:04 ` Suparna Bhattacharya
2003-04-24 5:11 ` Filesystem AIO read-write patches Suparna Bhattacharya
2003-04-24 5:11 ` Suparna Bhattacharya
2003-04-24 12:48 ` Matthew Wilcox
2003-04-24 12:48 ` Matthew Wilcox
2003-04-24 5:16 ` [PATCH 4/7] Filesystem AIO rdwr - async down (x86) Suparna Bhattacharya
2003-04-24 5:16 ` Suparna Bhattacharya
2003-04-24 5:19 ` [5/7] Filesystem AIO rdwr - use down_wq for aio write Suparna Bhattacharya
2003-04-24 5:19 ` Suparna Bhattacharya
2003-04-24 5:21 ` [PATCH 6/7] Filesystem AIO rdwr - async bread Suparna Bhattacharya
2003-04-24 5:21 ` Suparna Bhattacharya
2003-04-24 5:28 ` [PATCH 7/7] Filesystem AIO rdwr: async get block for ext2 Suparna Bhattacharya
2003-04-24 13:13 ` Benjamin LaHaise [this message]
2003-04-24 14:27 ` Filesystem AIO read-write patches Suparna Bhattacharya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030424091312.E9036@redhat.com \
--to=bcrl@redhat.com \
--cc=akpm@digeo.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.