All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: it87 driver converted to sysfs
Date: Thu, 19 May 2005 06:23:55 +0000	[thread overview]
Message-ID: <20030425221304.GA1657@kroah.com> (raw)
In-Reply-To: <20030425215335.GN1069@iucha.net>

On Fri, Apr 25, 2003 at 04:53:35PM -0500, Florin Iucha wrote:
> On Thu, Apr 24, 2003 at 10:27:58AM -0700, Greg KH wrote:
> > Thanks, I've applied this and will send it on in a bit.
> > 
> > Oops, I've fixed the call to check_region, which should not have been
> > made.  Sorry I missed that last time.
> 
> I have booted 2.5.68-bk6 and upon modprobe it87 I get this:

Let me know if this patch fixes it or not.

thanks,

greg k-h


--- a/drivers/i2c/chips/it87.c	Thu Apr 24 13:35:19 2003
+++ b/drivers/i2c/chips/it87.c	Fri Apr 25 15:06:21 2003
@@ -585,6 +585,7 @@
 		err = -ENOMEM;
 		goto ERROR1;
 	}
+	memset(new_client, 0x00, sizeof(struct i2c_client)+sizeof(struct it87_data));
 
 	data = (struct it87_data *) (new_client + 1);
 	if (is_isa)

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: it87 driver converted to sysfs
Date: Fri, 25 Apr 2003 15:13:04 -0700	[thread overview]
Message-ID: <20030425221304.GA1657@kroah.com> (raw)
In-Reply-To: <20030425215335.GN1069@iucha.net>

On Fri, Apr 25, 2003 at 04:53:35PM -0500, Florin Iucha wrote:
> On Thu, Apr 24, 2003 at 10:27:58AM -0700, Greg KH wrote:
> > Thanks, I've applied this and will send it on in a bit.
> > 
> > Oops, I've fixed the call to check_region, which should not have been
> > made.  Sorry I missed that last time.
> 
> I have booted 2.5.68-bk6 and upon modprobe it87 I get this:

Let me know if this patch fixes it or not.

thanks,

greg k-h


--- a/drivers/i2c/chips/it87.c	Thu Apr 24 13:35:19 2003
+++ b/drivers/i2c/chips/it87.c	Fri Apr 25 15:06:21 2003
@@ -585,6 +585,7 @@
 		err = -ENOMEM;
 		goto ERROR1;
 	}
+	memset(new_client, 0x00, sizeof(struct i2c_client)+sizeof(struct it87_data));
 
 	data = (struct it87_data *) (new_client + 1);
 	if (is_isa)

  reply	other threads:[~2005-05-19  6:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-24 15:01 it87 driver converted to sysfs Florin Iucha
2005-05-19  6:23 ` Florin Iucha
2003-04-24 16:04 ` Greg KH
2005-05-19  6:23   ` Greg KH
2003-04-24 16:51   ` Florin Iucha
2005-05-19  6:23     ` Florin Iucha
2003-04-24 17:27     ` Greg KH
2005-05-19  6:23       ` Greg KH
2003-04-25 21:53       ` Florin Iucha
2005-05-19  6:23         ` Florin Iucha
2003-04-25 22:13         ` Greg KH [this message]
2005-05-19  6:23           ` Greg KH
2003-04-25 22:52           ` Florin Iucha
2005-05-19  6:23             ` Florin Iucha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030425221304.GA1657@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.