All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ehci-hcd.c needs to include <linux/bitops.h>
@ 2003-05-13 15:53 Richard Curnow
  2003-05-13 20:39 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Curnow @ 2003-05-13 15:53 UTC (permalink / raw)
  To: Linux Kernel Mailing List

When I try to configure in EHCI support without this patch, I get
generic_ffs undefined at link time.  (This is with 2.4.21-rc2 on our
sh64 (SH-5) port).  Perhaps there are other ways to achieve this, but
this worked for me.

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1212  -> 1.1213 
#	drivers/usb/host/ehci-hcd.c	1.12    -> 1.13   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/05/13	curnowr@linsvr6.uk.superh.com	1.1213
# ehci-hcd.c needs to include <linux/bitops.h>, otherwise the inline
# definition of generic_ffs is not visible and it becomes an undefined
# symbol at link time.
# --------------------------------------------
#
diff -Nru a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
--- a/drivers/usb/host/ehci-hcd.c	Tue May 13 16:50:22 2003
+++ b/drivers/usb/host/ehci-hcd.c	Tue May 13 16:50:22 2003
@@ -31,6 +31,7 @@
 #include <linux/list.h>
 #include <linux/interrupt.h>
 #include <linux/reboot.h>
+#include <linux/bitops.h> /* for generic_ffs */
 
 #ifdef CONFIG_USB_DEBUG
 	#define DEBUG

-- 
Richard \\\ SuperH Core+Debug Architect /// .. At home ..
  P.    /// richard.curnow@superh.com  ///  rc@rc0.org.uk
Curnow  \\\ http://www.superh.com/    ///  www.rc0.org.uk
Speaking for myself, not on behalf of SuperH

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ehci-hcd.c needs to include <linux/bitops.h>
  2003-05-13 15:53 [PATCH] ehci-hcd.c needs to include <linux/bitops.h> Richard Curnow
@ 2003-05-13 20:39 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2003-05-13 20:39 UTC (permalink / raw)
  To: Linux Kernel Mailing List

On Tue, May 13, 2003 at 04:53:41PM +0100, Richard Curnow wrote:
> When I try to configure in EHCI support without this patch, I get
> generic_ffs undefined at link time.  (This is with 2.4.21-rc2 on our
> sh64 (SH-5) port).  Perhaps there are other ways to achieve this, but
> this worked for me.

Thanks, I've added this to my tree and will send it on.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-05-13 20:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-13 15:53 [PATCH] ehci-hcd.c needs to include <linux/bitops.h> Richard Curnow
2003-05-13 20:39 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.