All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javier Conti <av@labcc.ch>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: Fix for dell inspiron 8100 maestro3
Date: Sat, 17 May 2003 04:45:12 +0200	[thread overview]
Message-ID: <200305170445.13074.av@labcc.ch> (raw)
In-Reply-To: <s5hhe7vdjgc.wl@alsa2.suse.de>

[-- Attachment #1: Type: text/plain, Size: 743 bytes --]

On Friday 16 May 2003 17:01, Takashi Iwai wrote:
> are you sure that the patch is correct?
> your patch adds the same vendor an device id with the existing
> inspiron 8000 (1028:00a4).

Ok, I found the correct values, repatched and now the modules tells me the 
hack is enabled. With the other values, that didn't happen. Seen that, I 
tried to recompile a vanilla alsa-driver version, to see if my previous patch 
was doing some difference. The weird thing is that it still didn't work!
I'm puzzled, since the wrong patch fixed the problem anyway...

I'm sorry for the "noise" but hope to be helpful by sending this patch which 
includes the correct values.

Bye, Javier
-- 
Javier Conti - Labcc
Tel: +41(0)91 690 0703
Fax: +41(0)91 690 0702

[-- Attachment #2: maestro3.patch --]
[-- Type: text/x-diff, Size: 534 bytes --]

--- maestro3.c	2003-04-23 12:06:36.000000000 +0200
+++ /usr/src/modules/alsa-driver/alsa-kernel/pci/maestro3.c	2003-05-17 04:37:29.000000000 +0200
@@ -947,8 +947,14 @@
 		.amp_gpio = -1,
 		.irda_workaround = 1,
 	},
-	/* FIXME: Inspiron 8100 id should probably be here, too
-	 * (8200 irrelevant: has intel8x0 with CS4205) */
+	/* Dell Inspiron 8100 */
+	{
+		.name = "Dell Inspiron 8100",
+		.vendor = 0x1028,
+		.device = 0x00e6,
+		.amp_gpio = -1,
+		.irda_workaround = 1,
+	},
 	/* NEC LM800J/7 */
 	{
 		.name = "NEC LM800J/7",

  parent reply	other threads:[~2003-05-17  2:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-16 14:32 Fix for dell inspiron 8100 maestro3 Javier Conti
2003-05-16 15:01 ` Takashi Iwai
2003-05-17  1:58   ` Javier Conti
2003-05-17  2:45   ` Javier Conti [this message]
2003-05-19 11:24     ` Takashi Iwai
2003-05-20 13:01     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200305170445.13074.av@labcc.ch \
    --to=av@labcc.ch \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.