Re: Fix for dell inspiron 8100 maestro3

[Takashi Iwai <tiwai@suse.de>]

Hi,

At Fri, 16 May 2003 16:32:46 +0200,
Javier Conti wrote:
> 
> [1  <text/plain; iso-8859-15 (7bit)>]
> Hi, after a long and painful investigation on the maestro3 vs. irda problem on 
> the dell inspiron 8100 notebook, I found the FIXME tag in the maestro3 
> sources and, inspired by the 8000 fix right above, I applied the same fix for 
> 8100.
> 
> I'm no develper, but I think this should't break anything, and for me fixed 
> the problem on my 8100. Maybe someone will find this useful.
> 
> Patch attached, bye, Javier

are you sure that the patch is correct?
your patch adds the same vendor an device id with the existing
inspiron 8000 (1028:00a4).


Takashi

> -- 
> Javier Conti - Labcc
> http://www.labcc.ch/
> [2 maestro3.patch <text/x-diff; iso-8859-15 (7bit)>]
> --- maestro3.c	2003-04-23 12:06:36.000000000 +0200
> +++ /usr/src/modules/alsa-driver/alsa-kernel/pci/maestro3.c	2003-05-14 17:19:35.000000000 +0200
> @@ -949,6 +949,13 @@
>  	},
>  	/* FIXME: Inspiron 8100 id should probably be here, too
>  	 * (8200 irrelevant: has intel8x0 with CS4205) */
> +	{
> +		.name = "Dell Inspiron 8100",
> +		.vendor = 0x1028,
> +		.device = 0x00a4,
> +		.amp_gpio = -1,
> +		.irda_workaround = 1,
> +	},
>  	/* NEC LM800J/7 */
>  	{
>  		.name = "NEC LM800J/7",


-------------------------------------------------------
Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara
The only event dedicated to issues related to Linux enterprise solutions
www.enterpriselinuxforum.com