From: "David S. Miller" <davem@redhat.com>
To: schlicht@uni-mannheim.de
Cc: akpm@digeo.com, mfc@krycek.org, linux-kernel@vger.kernel.org
Subject: Re: Error during compile of 2.5.69-mm8
Date: Thu, 22 May 2003 17:23:04 -0700 (PDT) [thread overview]
Message-ID: <20030522.172304.08334616.davem@redhat.com> (raw)
In-Reply-To: <200305230213.39460.schlicht@uni-mannheim.de>
From: Thomas Schlichter <schlicht@uni-mannheim.de>
Date: Fri, 23 May 2003 02:13:34 +0200
> Therefore, it was a complete error for anyone else to start using this
> macro for other structures.
So nobody should better use THIS_MODULE?!
No, it is exactly what they should use.
They should avoid using SET_MODULE_OWNER.
For ME and many other driver developers SET_MODULE_OWNER does not belong to
netdevice, it belongs to the module infrastructure!
Then by changing SET_MODULE_OWNER you will break source backwards
compatability for every single network device driver out there,
something I was explicitly trying to avoid.
SET_MODULE_OWNER() is a bogus interface because it is typeless.
Therefore I suggest that you create macros specific to your individual
structures, and use these to achieve 2.4.x/2.5.x build compatability
in setting the ->owner field of such structs.
next prev parent reply other threads:[~2003-05-23 0:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-22 13:54 Error during compile of 2.5.69-mm8 Mads Christensen
2003-05-22 15:29 ` Mads Christensen
2003-05-22 23:10 ` Thomas Schlichter
[not found] ` <20030522160218.57b828db.akpm@digeo.com>
2003-05-22 23:05 ` David S. Miller
2003-05-22 23:28 ` Thomas Schlichter
2003-05-22 23:29 ` David S. Miller
2003-05-22 23:47 ` Thomas Schlichter
2003-05-22 23:48 ` David S. Miller
2003-05-23 0:13 ` Thomas Schlichter
2003-05-23 0:23 ` David S. Miller [this message]
2003-05-23 1:06 ` Thomas Schlichter
2003-05-23 1:16 ` David S. Miller
[not found] <200305230327.57985.schlicht@uni-mannheim.de>
[not found] ` <200305230538.38946.schlicht@uni-mannheim.de>
[not found] ` <20030522.213217.27796203.davem@redhat.com>
2003-05-24 14:36 ` Thomas Schlichter
2003-05-26 2:18 ` David S. Miller
2003-05-26 6:35 ` Thomas Schlichter
2003-05-26 7:04 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030522.172304.08334616.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfc@krycek.org \
--cc=schlicht@uni-mannheim.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.