From: Thomas Schlichter <schlicht@uni-mannheim.de>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Error during compile of 2.5.69-mm8
Date: Mon, 26 May 2003 08:35:53 +0200 [thread overview]
Message-ID: <200305260835.57145.schlicht@uni-mannheim.de> (raw)
In-Reply-To: <20030525.191818.48503212.davem@redhat.com>
Am Montag, 26. Mai 2003 04:18 schrieb David S. Miller:
> From: Thomas Schlichter <schlicht@uni-mannheim.de>
> Date: Sat, 24 May 2003 16:36:59 +0200
>
> I also attached a patch that fixes the SET_MODULE_OWNER thing for
> net/ipv4/ by using static initializers
>
> I can't apply these patches, there are errors. You remove
> the esp4_type->owner setting, but don't put the static initializer
> in there.
I created the patches against -mm8 with the SET_MODULE_OWNER lines modified by
hand to match your patched version, so the patches apply here cleanly...
> I suppose you do test the changes you make in your patches, right?
> What was the test you made to make sure the esp4_type module ownership
> was set correctly? :-)
Well, I looked into the code...
In version 1.26 of the file net/ipv4/esp.c rusty already added the static
initializer into the struct.
Best regards
Thomas Schlichter
next prev parent reply other threads:[~2003-05-26 6:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200305230327.57985.schlicht@uni-mannheim.de>
[not found] ` <200305230538.38946.schlicht@uni-mannheim.de>
[not found] ` <20030522.213217.27796203.davem@redhat.com>
2003-05-24 14:36 ` Error during compile of 2.5.69-mm8 Thomas Schlichter
2003-05-26 2:18 ` David S. Miller
2003-05-26 6:35 ` Thomas Schlichter [this message]
2003-05-26 7:04 ` David S. Miller
2003-05-22 13:54 Mads Christensen
2003-05-22 15:29 ` Mads Christensen
2003-05-22 23:10 ` Thomas Schlichter
[not found] ` <20030522160218.57b828db.akpm@digeo.com>
2003-05-22 23:05 ` David S. Miller
2003-05-22 23:28 ` Thomas Schlichter
2003-05-22 23:29 ` David S. Miller
2003-05-22 23:47 ` Thomas Schlichter
2003-05-22 23:48 ` David S. Miller
2003-05-23 0:13 ` Thomas Schlichter
2003-05-23 0:23 ` David S. Miller
2003-05-23 1:06 ` Thomas Schlichter
2003-05-23 1:16 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305260835.57145.schlicht@uni-mannheim.de \
--to=schlicht@uni-mannheim.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.