All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: chas@cmf.nrl.navy.mil
Cc: acme@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] assorted he driver cleanup
Date: Sun, 01 Jun 2003 18:32:35 -0700 (PDT)	[thread overview]
Message-ID: <20030601.183235.74726832.davem@redhat.com> (raw)
In-Reply-To: <200306011858.h51IwlsG022457@ginger.cmf.nrl.navy.mil>

   From: chas williams <chas@cmf.nrl.navy.mil>
   Date: Sun, 01 Jun 2003 14:57:02 -0400
   
   but on a single processor machine (i.e. #undef CONFIG_SMP) there is
   no chance that there will be reads/writes from other processors so
   i dont need any locking OR protection from interrupts.

Either you need to pretect a code sequence from an IRQ context
execution while holding the lock or you don't. :-)

Really, all your macros just make the driver that much less
portable.  And I don't see what you'll gain by having interrupts
enabled for such short sequences of code on uniprocessor.

  parent reply	other threads:[~2003-06-02  1:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-29 16:09 [PATCH][ATM] assorted he driver cleanup chas williams
2003-05-29 16:19 ` Christoph Hellwig
2003-05-29 16:32   ` chas williams
2003-05-29 16:21 ` Arnaldo Carvalho de Melo
2003-05-29 16:31   ` chas williams
2003-05-29 17:06     ` Arnaldo Carvalho de Melo
2003-05-29 17:12       ` chas williams
2003-05-29 17:36         ` Arnaldo Carvalho de Melo
2003-06-01 18:57           ` chas williams
2003-06-01 20:00             ` Alan Cox
2003-06-01 22:58               ` chas williams
2003-06-02  1:42                 ` David S. Miller
2003-06-02  1:47                   ` Arnaldo Carvalho de Melo
2003-06-02  2:34                   ` chas williams
2003-06-02 13:50                     ` Alan Cox
2003-06-02  1:32             ` David S. Miller [this message]
2003-05-29 18:08   ` chas williams
2003-05-29 18:34     ` Arnaldo Carvalho de Melo
2003-05-30  3:01 ` David S. Miller
2003-05-30  8:57   ` Dave Jones
2003-05-30 13:36     ` Jeff Garzik
2003-05-30 13:46   ` chas williams
2003-05-30 14:00     ` chas williams
     [not found]       ` <200305301431.h4UEVesG003572@ginger.cmf.nrl.navy.mil>
2003-06-04  4:51         ` David S. Miller
2003-06-01 22:42 ` Francois Romieu
2003-06-18 21:08   ` chas williams
2003-06-19  1:05     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030601.183235.74726832.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=acme@conectiva.com.br \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.