From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "David S. Miller" <davem@redhat.com>
Cc: chas@cmf.nrl.navy.mil, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ATM] assorted he driver cleanup
Date: Sun, 1 Jun 2003 22:47:24 -0300 [thread overview]
Message-ID: <20030602014723.GF4179@conectiva.com.br> (raw)
In-Reply-To: <20030601.184254.71111683.davem@redhat.com>
Em Sun, Jun 01, 2003 at 06:42:54PM -0700, David S. Miller escreveu:
> From: chas williams <chas@cmf.nrl.navy.mil>
> Date: Sun, 01 Jun 2003 18:58:26 -0400
>
> In message <1054497613.5863.4.camel@dhcp22.swansea.linux.org.uk>,Alan Cox writes:
> >Then why are you using spin_lock_irqsave ?
>
> meaning just use spin_lock() or what?
>
> Alan/Chas, there are two different issues here:
>
> 1) Aparently the bug only needs to be worked around when
> multiple cpus can access the card at the same time.
>
> Therefore on uniprocessor the bug isn't relevant.
>
> 2) Therefore, the lock needs to protect register accesses
> from all contexts. Therefore he needs an IRQ protecting
> lock.
>
> Therefore it isn't legal for him to use a non-IRQ protecting
> spinlock.
>
> I personally don't think it's worth all the maintainence cost
> to special case all of this junk for uniprocessor.
Agreed.
- Arnaldo
next prev parent reply other threads:[~2003-06-02 1:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-29 16:09 [PATCH][ATM] assorted he driver cleanup chas williams
2003-05-29 16:19 ` Christoph Hellwig
2003-05-29 16:32 ` chas williams
2003-05-29 16:21 ` Arnaldo Carvalho de Melo
2003-05-29 16:31 ` chas williams
2003-05-29 17:06 ` Arnaldo Carvalho de Melo
2003-05-29 17:12 ` chas williams
2003-05-29 17:36 ` Arnaldo Carvalho de Melo
2003-06-01 18:57 ` chas williams
2003-06-01 20:00 ` Alan Cox
2003-06-01 22:58 ` chas williams
2003-06-02 1:42 ` David S. Miller
2003-06-02 1:47 ` Arnaldo Carvalho de Melo [this message]
2003-06-02 2:34 ` chas williams
2003-06-02 13:50 ` Alan Cox
2003-06-02 1:32 ` David S. Miller
2003-05-29 18:08 ` chas williams
2003-05-29 18:34 ` Arnaldo Carvalho de Melo
2003-05-30 3:01 ` David S. Miller
2003-05-30 8:57 ` Dave Jones
2003-05-30 13:36 ` Jeff Garzik
2003-05-30 13:46 ` chas williams
2003-05-30 14:00 ` chas williams
[not found] ` <200305301431.h4UEVesG003572@ginger.cmf.nrl.navy.mil>
2003-06-04 4:51 ` David S. Miller
2003-06-01 22:42 ` Francois Romieu
2003-06-18 21:08 ` chas williams
2003-06-19 1:05 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030602014723.GF4179@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.