All of lore.kernel.org
 help / color / mirror / Atom feed
* 2.4 v. 2.5 nfs_dentry_iput()
@ 2003-06-02  9:15 Frank Cusack
  2003-06-02 19:52 ` Trond Myklebust
  0 siblings, 1 reply; 2+ messages in thread
From: Frank Cusack @ 2003-06-02  9:15 UTC (permalink / raw)
  To: Linux Kernel Mailing List

Hi,

Could someone quickly explain the difference between the 2.4.20 and 2.5.69
nfs_dentry_iput()?

static void nfs_dentry_iput(struct dentry *dentry, struct inode *inode)
{
        if (dentry->d_flags & DCACHE_NFSFS_RENAMED) {
                lock_kernel();
		inode->i_nlink--;		/* only in 2.5 */
                nfs_complete_unlink(dentry);
                unlock_kernel();
        }
        if (is_bad_inode(inode))		/* not in 2.5 */
                force_delete(inode);		/* not in 2.5 */
        /* When creating a negative dentry, we want to renew d_time */
        nfs_renew_times(dentry);		/* only in 2.5 */
        iput(inode);
}

Thanks,
/fc

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 2.4 v. 2.5 nfs_dentry_iput()
  2003-06-02  9:15 2.4 v. 2.5 nfs_dentry_iput() Frank Cusack
@ 2003-06-02 19:52 ` Trond Myklebust
  0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2003-06-02 19:52 UTC (permalink / raw)
  To: Frank Cusack; +Cc: Linux Kernel Mailing List

>>>>> " " == Frank Cusack <fcusack@fcusack.com> writes:

     > Hi, Could someone quickly explain the difference between the
     > 2.4.20 and 2.5.69 nfs_dentry_iput()?

     > static void nfs_dentry_iput(struct dentry *dentry, struct inode
     > *inode) {
     >         if (dentry->d_flags & DCACHE_NFSFS_RENAMED) {
     >                 lock_kernel();
     >                 inode-> i_nlink--; /* only in 2.5 */

Should eventually go into 2.4.x. Not critical...

     >                 nfs_complete_unlink(dentry); unlock_kernel();
     >         } if (is_bad_inode(inode)) /* not in 2.5 */
     >                 force_delete(inode); /* not in 2.5 */

Done in the VFS in 2.5

     >         /* When creating a negative dentry, we want to renew
     >         d_time */ nfs_renew_times(dentry); /* only in 2.5 */

Only needed for the new CTO code in 2.5.

     >         iput(inode);
     > }

Cheers,
  Trond

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-06-02 19:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-06-02  9:15 2.4 v. 2.5 nfs_dentry_iput() Frank Cusack
2003-06-02 19:52 ` Trond Myklebust

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.