From: Jeff Garzik <jgarzik@pobox.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Stewart Smith <stewartsmith@mac.com>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org,
Stewart Smith <stewart@linux.org.au>
Subject: Re: [PATCH] fixed: CRC32=y && 8193TOO=m unresolved symbols
Date: Wed, 4 Jun 2003 11:32:24 -0400 [thread overview]
Message-ID: <20030604153224.GF19929@gtf.org> (raw)
In-Reply-To: <1054740649.17921.292.camel@passion.cambridge.redhat.com>
On Wed, Jun 04, 2003 at 04:30:49PM +0100, David Woodhouse wrote:
> On Wed, 2003-06-04 at 16:28, Jeff Garzik wrote:
>
> > You can't EXPORT_SYMBOL from a header.
> >
> > This sounds like Kconfig or Makefile bugs to me... all the
> > export-symbol stuff should already be in place.
> >
> > Can you post your .config and the exact build errors you are getting?
>
> It's because lib/crc32.o isn't actually _referenced_ by anything, hence
> isn't actually pulled into vmlinux from lib/lib.a.
>
> My fix in the 2.4 tree is to export its symbols from kernel/ksyms.c
> #ifdef CONFIG_CRC32, and to export its symbols from lib/crc32.c
> #ifndef CONFIG_CRC32.
That makes sense.
Any opinions on moving it out of lib/lib.a?
We have our own conditional linking system, essentially, so that's what
I would prefer.
Jeff
next prev parent reply other threads:[~2003-06-04 15:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-03 1:13 CRC32=y && 8193TOO=m unresolved symbols Stewart Smith
2003-06-03 13:16 ` David Woodhouse
2003-06-04 5:56 ` [PATCH] fixed: " Stewart Smith
2003-06-04 15:28 ` Jeff Garzik
2003-06-04 15:30 ` David Woodhouse
2003-06-04 15:32 ` Jeff Garzik [this message]
2003-06-04 15:41 ` Linus Torvalds
2003-06-07 7:33 ` [EVIL-PATCH] getting rid of lib/lib.a and breaking many archs in the processes (was Re: [PATCH] fixed: CRC32=y && 8193TOO=m unresolved symbols) Stewart Smith
2003-06-07 7:39 ` Christoph Hellwig
2003-06-07 17:34 ` Linus Torvalds
2003-06-07 19:02 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030604153224.GF19929@gtf.org \
--to=jgarzik@pobox.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stewart@linux.org.au \
--cc=stewartsmith@mac.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.