All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
	James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org,
	rmk@arm.linux.org.uk
Subject: Re: [PATCH] kill of ->command
Date: Mon, 9 Jun 2003 20:11:48 +0200	[thread overview]
Message-ID: <20030609181148.GA3121@lst.de> (raw)
In-Reply-To: <20030609110413.A15239@beaverton.ibm.com>

On Mon, Jun 09, 2003 at 11:04:13AM -0700, Patrick Mansfield wrote:
> The patch is a good idea, we ought to keep it.
> 
> We could move the ->command code (check for can_queue == 0) into the
> drivers queuecommand function, and let them call their own "command"
> function.

Well, the scsi midlayer handling for the two variants is a bit
different.  But I think just disabling support for the can_queue == 0
in NCR53c406a.c should be fine as it's a parameter whether to use
irqs (can_queue == 1) or not.

I'd just love to hear a comment from rmk on arxescsi.c.

  reply	other threads:[~2003-06-09 17:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-09 16:20 [PATCH] kill of ->command Christoph Hellwig
2003-06-09 16:41 ` Patrick Mansfield
2003-06-09 16:51   ` Christoph Hellwig
2003-06-09 18:04     ` Patrick Mansfield
2003-06-09 18:11       ` Christoph Hellwig [this message]
2003-06-09 18:15     ` Russell King
2003-06-09 18:19       ` James Bottomley
2003-06-09 18:22         ` Russell King
2003-06-09 18:32 ` Matthew Dharm
2003-06-09 18:34   ` Christoph Hellwig
2003-06-09 18:37   ` Jeff Garzik
2003-06-09 18:45     ` Matthew Dharm
2003-06-09 19:05       ` Jeff Garzik
2003-06-09 19:19       ` Tony Battersby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030609181148.GA3121@lst.de \
    --to=hch@lst.de \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=patmans@us.ibm.com \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.