All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Patrick Mansfield <patmans@us.ibm.com>,
	James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] kill of ->command
Date: Mon, 9 Jun 2003 19:15:52 +0100	[thread overview]
Message-ID: <20030609191552.A2006@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20030609165157.GA2079@lst.de>; from hch@lst.de on Mon, Jun 09, 2003 at 06:51:57PM +0200

On Mon, Jun 09, 2003 at 06:51:57PM +0200, Christoph Hellwig wrote:
> > and drivers/scsi/arm/arxescsi.c
> > can still set can_queue = 0. Correct?
> 
> Russell, and idea why this one sets can_queue = 0 but implements
> ->queuecommand?

I would guess its because the author just did a cut and paste followed
by minimum editing to make it work.

I'd need to look at the code, but I'd imagine we could probably do
everything we need to inside ->queuecommand that's currently being
done by ->command.  My only concern would be calling the done
function from within queuecommand.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


  parent reply	other threads:[~2003-06-09 18:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-09 16:20 [PATCH] kill of ->command Christoph Hellwig
2003-06-09 16:41 ` Patrick Mansfield
2003-06-09 16:51   ` Christoph Hellwig
2003-06-09 18:04     ` Patrick Mansfield
2003-06-09 18:11       ` Christoph Hellwig
2003-06-09 18:15     ` Russell King [this message]
2003-06-09 18:19       ` James Bottomley
2003-06-09 18:22         ` Russell King
2003-06-09 18:32 ` Matthew Dharm
2003-06-09 18:34   ` Christoph Hellwig
2003-06-09 18:37   ` Jeff Garzik
2003-06-09 18:45     ` Matthew Dharm
2003-06-09 19:05       ` Jeff Garzik
2003-06-09 19:19       ` Tony Battersby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030609191552.A2006@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=James.Bottomley@steeleye.com \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=patmans@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.