From: Dipankar Sarma <dipankar@in.ibm.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: John M Flinchbaugh <glynis@butterfly.hjsoft.com>,
linux-kernel@vger.kernel.org,
Trond Myklebust <trond.myklebust@fys.uio.no>,
Maneesh Soni <maneesh@in.ibm.com>
Subject: Re: 2.5.70-bk16: nfs crash
Date: Thu, 12 Jun 2003 21:35:57 +0530 [thread overview]
Message-ID: <20030612160557.GC1438@in.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0306120847540.2742-100000@home.transmeta.com>
On Thu, Jun 12, 2003 at 08:49:53AM -0700, Linus Torvalds wrote:
> On Thu, 12 Jun 2003, Dipankar Sarma wrote:
> >
> > hlist poison patch is broken. list_del_rcu() and hlist_del_rcu()
> > *must not* re-initialize the pointers. Maneesh submitted a patch
> > earlier today that corrects this -
>
> Sorry, but you're wrong.
>
> If you depend on not re-initializing the pointers, you should not use the
> "xxx_del()" function, and you should document it.
Right. That is why they are list_del_rcu() and hlist_del_rcu().
The comments for list_del_rcu() clearly say that pointers
are not re-initialized.
>
> This is that the __xxx_del() functions are there for - they won't do the
> poisoning. The regular delete functions have historically always poisoned
> the pointers - it was only removed a few months ago by Andrew.
Poisoning xxx_del() functions is ok. That should be done.
Thanks
Dipankar
next prev parent reply other threads:[~2003-06-12 15:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-12 12:56 2.5.70-bk16: nfs crash John M Flinchbaugh
2003-06-12 13:52 ` Dipankar Sarma
2003-06-12 15:33 ` Dipankar Sarma
2003-06-12 15:35 ` Trond Myklebust
2003-06-12 15:53 ` Dipankar Sarma
2003-06-12 16:26 ` Trond Myklebust
2003-06-12 16:49 ` Linus Torvalds
2003-06-12 16:55 ` Linus Torvalds
2003-06-12 19:53 ` Dipankar Sarma
2003-06-13 5:24 ` Trond Myklebust
2003-06-13 5:50 ` Dipankar Sarma
2003-06-13 6:13 ` Trond Myklebust
2003-06-13 6:54 ` Dipankar Sarma
2003-06-13 6:06 ` Dipankar Sarma
2003-06-12 16:30 ` viro
2003-06-12 16:55 ` Dipankar Sarma
2003-06-12 15:49 ` Linus Torvalds
2003-06-12 16:05 ` Dipankar Sarma [this message]
2003-06-12 16:18 ` Linus Torvalds
2003-06-12 16:35 ` Dipankar Sarma
2003-06-12 16:47 ` Linus Torvalds
2003-06-13 12:48 ` Maneesh Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030612160557.GC1438@in.ibm.com \
--to=dipankar@in.ibm.com \
--cc=glynis@butterfly.hjsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=torvalds@transmeta.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.