From: Maneesh Soni <maneesh@in.ibm.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Dipankar Sarma <dipankar@in.ibm.com>,
John M Flinchbaugh <glynis@butterfly.hjsoft.com>,
linux-kernel@vger.kernel.org,
Trond Myklebust <trond.myklebust@fys.uio.no>,
Andrew Morton <akpm@digeo.com>
Subject: Re: 2.5.70-bk16: nfs crash
Date: Fri, 13 Jun 2003 18:18:54 +0530 [thread overview]
Message-ID: <20030613124854.GB1204@in.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0306120915190.2742-100000@home.transmeta.com>
On Thu, Jun 12, 2003 at 09:18:11AM -0700, Linus Torvalds wrote:
>
>
[..]
> ---
> ===== include/linux/dcache.h 1.32 vs edited =====
> --- 1.32/include/linux/dcache.h Tue Jun 10 14:56:43 2003
> +++ edited/include/linux/dcache.h Thu Jun 12 09:12:27 2003
> @@ -174,8 +174,10 @@
>
> static inline void __d_drop(struct dentry *dentry)
> {
> - dentry->d_vfs_flags |= DCACHE_UNHASHED;
> - hlist_del_rcu_init(&dentry->d_hash);
> + if (!(dentry->d_vfs_flags & DCACHE_UNHASHED)) {
> + dentry->d_vfs_flags |= DCACHE_UNHASHED;
> + hlist_del_rcu(&dentry->d_hash);
> + }
> }
Looks like there is some problem in this. With this conditional
d_drop, umounting an NFS mount goes in a loop and oopses in dput()
This is on 2.5.70-bk17.
Unable to handle kernel paging request at virtual address 00100104
printing eip:
c016f9b1
*pde = 00000000
Oops: 0002 [#1]
CPU: 3
EIP: 0060:[<c016f9b1>] Not tainted
EFLAGS: 00010246
EIP is at dput+0x1f1/0x350
eax: 00100100 ebx: f72a8c80 ecx: f72a8c9c edx: 00200200
esi: f64d2000 edi: f72a8c88 ebp: 00000000 esp: f64d3e8c
ds: 007b es: 007b ss: 0068
Process umount (pid: 926, threadinfo=f64d2000 task=f79d9900)
Stack: 00000010 c016007b 0000007b ffffffef f72a8c80 f6448380 f64481e0 c02fccca
f72a8c80 f6448380 f72a8cf8 f72a8820 f72a8820 f6448860 c035f8e0 c02fd1c0
f72a8820 f78775e0 f7fde560 f74971d9 00000005 10ee271a 00000010 00000000
Call Trace:
[<c016007b>] bd_claim+0x2b/0xa0
[<c02fccca>] rpc_depopulate+0x16a/0x190
[<c02fd1c0>] rpc_rmdir+0x60/0xa0
[<c02f2a4d>] rpcauth_destroy+0xd/0x60
[<c02ec45d>] rpc_destroy_client+0x4d/0x70
[<c01b6427>] nfs_put_super+0x17/0x40
[<c015e03f>] generic_shutdown_super+0xbf/0x200
[<c015eec0>] kill_anon_super+0x10/0x80
[<c01b8811>] nfs_kill_super+0x11/0x20
[<c015dcf9>] deactivate_super+0xa9/0x140
[<c0175d08>] __mntput+0x18/0x30
[<c0165e79>] path_release+0x29/0x30
[<c0176641>] sys_umount+0x81/0x90
[<c015710f>] sys_close+0x9f/0x100
[<c017665c>] sys_oldumount+0xc/0x10
[<c0109477>] syscall_call+0x7/0xb
Removing the DCACHE_UNHASHED check makes it work again. Needs more
investigation.
--
Maneesh Soni
IBM Linux Technology Center,
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: maneesh@in.ibm.com
http://lse.sourceforge.net/
prev parent reply other threads:[~2003-06-13 12:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-12 12:56 2.5.70-bk16: nfs crash John M Flinchbaugh
2003-06-12 13:52 ` Dipankar Sarma
2003-06-12 15:33 ` Dipankar Sarma
2003-06-12 15:35 ` Trond Myklebust
2003-06-12 15:53 ` Dipankar Sarma
2003-06-12 16:26 ` Trond Myklebust
2003-06-12 16:49 ` Linus Torvalds
2003-06-12 16:55 ` Linus Torvalds
2003-06-12 19:53 ` Dipankar Sarma
2003-06-13 5:24 ` Trond Myklebust
2003-06-13 5:50 ` Dipankar Sarma
2003-06-13 6:13 ` Trond Myklebust
2003-06-13 6:54 ` Dipankar Sarma
2003-06-13 6:06 ` Dipankar Sarma
2003-06-12 16:30 ` viro
2003-06-12 16:55 ` Dipankar Sarma
2003-06-12 15:49 ` Linus Torvalds
2003-06-12 16:05 ` Dipankar Sarma
2003-06-12 16:18 ` Linus Torvalds
2003-06-12 16:35 ` Dipankar Sarma
2003-06-12 16:47 ` Linus Torvalds
2003-06-13 12:48 ` Maneesh Soni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030613124854.GB1204@in.ibm.com \
--to=maneesh@in.ibm.com \
--cc=akpm@digeo.com \
--cc=dipankar@in.ibm.com \
--cc=glynis@butterfly.hjsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.