All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Dave McCracken <dmccr@us.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix vmtruncate race and distributed filesystem race
Date: Thu, 12 Jun 2003 16:07:40 -0700	[thread overview]
Message-ID: <20030612160740.27a57aca.akpm@digeo.com> (raw)
In-Reply-To: <184910000.1055458610@baldur.austin.ibm.com>

Dave McCracken <dmccr@us.ibm.com> wrote:
>
> I also think if we can solve both the vmtruncate and the distributed file
> system races without adding any vm_ops, we should.
> 
> Here's a new patch.  Does this look better?

grumble, mutter.  It's certainly simple enough.

+	mapping = vma->vm_file->f_dentry->d_inode->i_mapping;

I'm not so sure about this one now.  write() alters dentry->d_inode but
truncate alters dentry->d_inode->i_mapping->host.  Unless truncate is
changed we have the wrong mapping here.

I'll put it back to the original while I try to work out why truncate isn't
wrong...


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@digeo.com>
To: Dave McCracken <dmccr@us.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix vmtruncate race and distributed filesystem race
Date: Thu, 12 Jun 2003 16:07:40 -0700	[thread overview]
Message-ID: <20030612160740.27a57aca.akpm@digeo.com> (raw)
In-Reply-To: <184910000.1055458610@baldur.austin.ibm.com>

Dave McCracken <dmccr@us.ibm.com> wrote:
>
> I also think if we can solve both the vmtruncate and the distributed file
> system races without adding any vm_ops, we should.
> 
> Here's a new patch.  Does this look better?

grumble, mutter.  It's certainly simple enough.

+	mapping = vma->vm_file->f_dentry->d_inode->i_mapping;

I'm not so sure about this one now.  write() alters dentry->d_inode but
truncate alters dentry->d_inode->i_mapping->host.  Unless truncate is
changed we have the wrong mapping here.

I'll put it back to the original while I try to work out why truncate isn't
wrong...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  reply	other threads:[~2003-06-12 22:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-12 20:16 [PATCH] Fix vmtruncate race and distributed filesystem race Dave McCracken
2003-06-12 20:49 ` Andrew Morton
2003-06-12 20:49   ` Andrew Morton
2003-06-12 21:00   ` Andrew Morton
2003-06-12 21:00     ` Andrew Morton
2003-06-12 21:08     ` Dave McCracken
2003-06-12 21:08       ` Dave McCracken
2003-06-12 21:44       ` Andrew Morton
2003-06-12 21:44         ` Andrew Morton
2003-06-12 22:56         ` Dave McCracken
2003-06-12 23:07           ` Andrew Morton [this message]
2003-06-12 23:07             ` Andrew Morton
2003-06-20  0:17           ` Andrea Arcangeli
2003-06-20  0:17             ` Andrea Arcangeli
2003-06-23  3:28             ` Paul E. McKenney
2003-06-23  3:28               ` Paul E. McKenney
2003-06-23  6:29               ` Andrea Arcangeli
2003-06-23  6:29                 ` Andrea Arcangeli
2003-06-23  6:32               ` Andrew Morton
2003-06-23  6:32                 ` Andrew Morton
2003-06-23  7:43                 ` Andrea Arcangeli
2003-06-23  7:43                   ` Andrea Arcangeli
2003-06-23  7:56                   ` Andrew Morton
2003-06-23  7:56                     ` Andrew Morton
2003-06-23  8:10                     ` Andrea Arcangeli
2003-06-23  8:10                       ` Andrea Arcangeli
2003-06-24  1:37                       ` Paul E. McKenney
2003-06-24  1:37                         ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030612160740.27a57aca.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=dmccr@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.