From: greg@kroah.com (Greg KH)
To: Martin Schlemmer <azarah@gentoo.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Sensors <sensors@stimpy.netroedge.com>,
"Mark M. Hoffman" <mhoffman@lightlink.com>
Subject: [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS w83781d
Date: Thu, 19 May 2005 06:24:00 +0000 [thread overview]
Message-ID: <20030616184149.GC25585@kroah.com> (raw)
In-Reply-To: <1055571995.12868.5.camel@nosferatu.lan>
On Sat, Jun 14, 2003 at 08:26:35AM +0200, Martin Schlemmer wrote:
> On Fri, 2003-06-13 at 04:36, Mark M. Hoffman wrote:
> > > > > Anyhow, Only change I have made to the w83781d driver, is one line
> > > > > (just tell it to that if the chip id is 0x72, its also of type
> > > > > w83726HF), but now (2.5.70-bk1[123]) it segfaults for me on rmmod, where
> > > > > it did not with 2.5.68 kernels when I still had the other board. I will
> > > > > attach a oops tomorrow or such when I get home.
> > > >
>
> > My first patch was naive; the patch below solves the problem by
> > letting w83781d_detach_client remove the three clients (1 * primary
> > + 2 * subclients) independently. It's a noisy patch because I had
> > to change the way the subclients were kmalloc'ed - sorry. The meat
> > is around line 1422. This patch works for me... comments?
> >
> > Regards,
> >
> > ---
> > Mark M. Hoffman
> > mhoffman@lightlink.com
>
> Greg, this patch from Mark fixes it, please include in your stuff
> to send to Linus.
Applied, thanks.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Martin Schlemmer <azarah@gentoo.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Sensors <sensors@stimpy.netroedge.com>,
"Mark M. Hoffman" <mhoffman@lightlink.com>
Subject: Re: [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS w83781d during rmmod (2.5.70-bk1[1234]))
Date: Mon, 16 Jun 2003 11:41:49 -0700 [thread overview]
Message-ID: <20030616184149.GC25585@kroah.com> (raw)
In-Reply-To: <1055571995.12868.5.camel@nosferatu.lan>
On Sat, Jun 14, 2003 at 08:26:35AM +0200, Martin Schlemmer wrote:
> On Fri, 2003-06-13 at 04:36, Mark M. Hoffman wrote:
> > > > > Anyhow, Only change I have made to the w83781d driver, is one line
> > > > > (just tell it to that if the chip id is 0x72, its also of type
> > > > > w83726HF), but now (2.5.70-bk1[123]) it segfaults for me on rmmod, where
> > > > > it did not with 2.5.68 kernels when I still had the other board. I will
> > > > > attach a oops tomorrow or such when I get home.
> > > >
>
> > My first patch was naive; the patch below solves the problem by
> > letting w83781d_detach_client remove the three clients (1 * primary
> > + 2 * subclients) independently. It's a noisy patch because I had
> > to change the way the subclients were kmalloc'ed - sorry. The meat
> > is around line 1422. This patch works for me... comments?
> >
> > Regards,
> >
> > ---
> > Mark M. Hoffman
> > mhoffman@lightlink.com
>
> Greg, this patch from Mark fixes it, please include in your stuff
> to send to Linus.
Applied, thanks.
greg k-h
next prev parent reply other threads:[~2005-05-19 6:24 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-24 18:37 [OOPS] w83781d during rmmod (2.5.69-bk17) Mark M. Hoffman
2005-05-19 6:23 ` Mark M. Hoffman
2005-05-19 6:23 ` Mark D. Studebaker
2003-06-01 14:38 ` [RFC PATCH] " Mark M. Hoffman
2005-05-19 6:23 ` Mark M. Hoffman
2003-06-02 17:20 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-06-03 5:22 ` Martin Schlemmer
2005-05-19 6:23 ` Martin Schlemmer
2003-06-03 19:43 ` Philip Pokorny
2005-05-19 6:23 ` Philip Pokorny
2003-06-04 5:57 ` Martin Schlemmer
2005-05-19 6:23 ` Martin Schlemmer
2003-06-05 2:39 ` Mark M. Hoffman
2005-05-19 6:23 ` Mark M. Hoffman
2003-06-05 19:47 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-06-09 5:34 ` Martin Schlemmer
2005-05-19 6:23 ` Martin Schlemmer
2003-06-10 5:38 ` Martin Schlemmer
2005-05-19 6:23 ` Martin Schlemmer
2003-06-10 5:41 ` OOPS w83781d during rmmod (2.5.70-bk1[1234]) Mark M. Hoffman
2005-05-19 6:23 ` Mark M. Hoffman
2003-06-10 5:51 ` Martin Schlemmer
2005-05-19 6:23 ` Martin Schlemmer
2003-06-11 5:44 ` Martin Schlemmer
2005-05-19 6:23 ` Martin Schlemmer
2003-06-12 6:57 ` [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS w83781d during rmmod (2.5.70-bk1[1234])) Martin Schlemmer
2005-05-19 6:23 ` [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS w83781d Martin Schlemmer
2003-06-13 2:36 ` [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS w83781d during rmmod (2.5.70-bk1[1234])) Mark M. Hoffman
2005-05-19 6:23 ` [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS w83781d Mark M. Hoffman
2003-06-13 6:08 ` [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS w83781d during rmmod (2.5.70-bk1[1234])) Martin Schlemmer
2005-05-19 6:23 ` [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS Martin Schlemmer
2003-06-14 6:26 ` [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS w83781d during rmmod (2.5.70-bk1[1234])) Martin Schlemmer
2005-05-19 6:24 ` [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS Martin Schlemmer
2003-06-16 18:41 ` Greg KH [this message]
2005-05-19 6:24 ` [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS w83781d Greg KH
2003-09-03 20:54 ` [PATCH 2.6] Fix conversion from milli volts in store_in_reg() for w83781d.c Martin Schlemmer
2005-05-19 6:24 ` [PATCH 2.6] Fix conversion from milli volts in store_in_reg() for Martin Schlemmer
2003-09-04 18:40 ` [PATCH 2.6] Fix conversion from milli volts in store_in_reg() for w83781d.c Greg KH
2005-05-19 6:24 ` [PATCH 2.6] Fix conversion from milli volts in store_in_reg() for Greg KH
2003-09-07 15:41 ` [PATCH 2.6] Fix conversion from milli volts in store_in_reg() for w83781d.c Andrey Borzenkov
2005-05-19 6:24 ` [PATCH 2.6] Fix conversion from milli volts in store_in_reg() for Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030616184149.GC25585@kroah.com \
--to=greg@kroah.com \
--cc=azarah@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhoffman@lightlink.com \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.