From: greg@kroah.com (Greg KH)
To: LKML <linux-kernel@vger.kernel.org>,
Sensors <sensors@stimpy.netroedge.com>
Subject: [RFC PATCH] Add lm78 sensor chip support (2.5.70)
Date: Thu, 19 May 2005 06:24:00 +0000 [thread overview]
Message-ID: <20030616184213.GE25585@kroah.com> (raw)
In-Reply-To: <20030608223334.GC30962@earth.solarsys.private>
On Sun, Jun 08, 2003 at 06:33:34PM -0400, Mark M. Hoffman wrote:
> This patch vs. 2.5.70 adds support for LM78, LM78-J, and LM79 sensors
> chips based on lm_sensors project CVS. This works on one of my boards.
>
> I want to draw attention to something I did with this driver by
> comparing it to it87.c in 2.5.70:
>
> > #define IT87_INIT_TEMP_HIGH_1 600
> > #define IT87_INIT_TEMP_LOW_1 200
>
> The hardware uses degrees C, and sysfs uses degrees C * 1000. But
> these #defines are apparently in units of degrees C * 10. This
> arbitrary intermediate representation bugs me. And given the new 2.5
> sysfs standard, it's unnecessary.
>
> In this patch for lm78, I rewrote the conversion routines in terms
> of the sysfs units - getting rid of the intermediate nonsense. If
> there are no objections, I'm going to start passing patches to do
> this to the other sensor chip drivers in 2.5 as well. It would be
> nice to get some help with this too... especially since I don't
> have all that hardware at hand to test the results.
Applied, thanks.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: LKML <linux-kernel@vger.kernel.org>,
Sensors <sensors@stimpy.netroedge.com>
Subject: Re: [RFC PATCH] Add lm78 sensor chip support (2.5.70)
Date: Mon, 16 Jun 2003 11:42:13 -0700 [thread overview]
Message-ID: <20030616184213.GE25585@kroah.com> (raw)
In-Reply-To: <20030608223334.GC30962@earth.solarsys.private>
On Sun, Jun 08, 2003 at 06:33:34PM -0400, Mark M. Hoffman wrote:
> This patch vs. 2.5.70 adds support for LM78, LM78-J, and LM79 sensors
> chips based on lm_sensors project CVS. This works on one of my boards.
>
> I want to draw attention to something I did with this driver by
> comparing it to it87.c in 2.5.70:
>
> > #define IT87_INIT_TEMP_HIGH_1 600
> > #define IT87_INIT_TEMP_LOW_1 200
>
> The hardware uses degrees C, and sysfs uses degrees C * 1000. But
> these #defines are apparently in units of degrees C * 10. This
> arbitrary intermediate representation bugs me. And given the new 2.5
> sysfs standard, it's unnecessary.
>
> In this patch for lm78, I rewrote the conversion routines in terms
> of the sysfs units - getting rid of the intermediate nonsense. If
> there are no objections, I'm going to start passing patches to do
> this to the other sensor chip drivers in 2.5 as well. It would be
> nice to get some help with this too... especially since I don't
> have all that hardware at hand to test the results.
Applied, thanks.
greg k-h
next prev parent reply other threads:[~2005-05-19 6:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-08 22:33 [RFC PATCH] Add lm78 sensor chip support (2.5.70) Mark M. Hoffman
2005-05-19 6:23 ` Mark M. Hoffman
2003-06-13 23:11 ` Greg KH
2005-05-19 6:23 ` Greg KH
2003-06-14 1:47 ` Mark M. Hoffman
2005-05-19 6:23 ` Mark M. Hoffman
2003-06-16 18:42 ` Greg KH [this message]
2005-05-19 6:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030616184213.GE25585@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.