From: Russell King <rmk@arm.linux.org.uk>
To: Linux Kernel List <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@cambridge.redhat.com>
Subject: [PATCH] Fix mtdblock / mtdpart / mtdconcat
Date: Mon, 23 Jun 2003 01:00:31 +0100 [thread overview]
Message-ID: <20030623010031.E16537@flint.arm.linux.org.uk> (raw)
Dirtily disable ECC support; it doesn't work when mtdpart is layered
on top of mtdconcat on top of CFI flash.
There is probably a better fix, but that's for someone else to find.
--- orig/drivers/mtd/mtdpart.c Sat Jun 14 22:33:58 2003
+++ linux/drivers/mtd/mtdpart.c Mon Jun 23 00:55:04 2003
@@ -55,12 +55,12 @@
len = 0;
else if (from + len > mtd->size)
len = mtd->size - from;
- if (part->master->read_ecc == NULL)
+// if (part->master->read_ecc == NULL)
return part->master->read (part->master, from + part->offset,
len, retlen, buf);
- else
- return part->master->read_ecc (part->master, from + part->offset,
- len, retlen, buf, NULL, &mtd->oobinfo);
+// else
+// return part->master->read_ecc (part->master, from + part->offset,
+// len, retlen, buf, NULL, &mtd->oobinfo);
}
static int part_point (struct mtd_info *mtd, loff_t from, size_t len,
@@ -134,12 +134,12 @@
len = 0;
else if (to + len > mtd->size)
len = mtd->size - to;
- if (part->master->write_ecc == NULL)
+// if (part->master->write_ecc == NULL)
return part->master->write (part->master, to + part->offset,
len, retlen, buf);
- else
- return part->master->write_ecc (part->master, to + part->offset,
- len, retlen, buf, NULL, &mtd->oobinfo);
+// else
+// return part->master->write_ecc (part->master, to + part->offset,
+// len, retlen, buf, NULL, &mtd->oobinfo);
}
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next reply other threads:[~2003-06-22 23:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-23 0:00 Russell King [this message]
2003-06-23 7:19 ` [PATCH] Fix mtdblock / mtdpart / mtdconcat David Woodhouse
2003-06-23 7:22 ` Russell King
2003-06-23 7:32 ` David Woodhouse
2003-06-23 8:00 ` Russell King
2003-06-25 12:43 ` David Woodhouse
2003-06-25 12:43 ` David Woodhouse
2003-06-29 20:34 ` Russell King
2003-06-29 20:34 ` Russell King
2003-06-29 21:27 ` David Woodhouse
2003-06-29 21:27 ` David Woodhouse
2003-06-30 6:08 ` David Woodhouse
2003-06-30 6:08 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030623010031.E16537@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=dwmw2@cambridge.redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.