All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@redhat.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: linux-mtd@lists.infradead.org
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix mtdblock / mtdpart / mtdconcat
Date: Sun, 29 Jun 2003 22:27:25 +0100	[thread overview]
Message-ID: <1056922045.6616.28.camel@lapdancer.baythorne.internal> (raw)
In-Reply-To: <20030629213450.B5653@flint.arm.linux.org.uk>

On Sun, 2003-06-29 at 21:34, Russell King wrote:
> While looking over the changes between 1.5 and 1.6, I spotted this.  You
> may want to fix this change:
> 
> -                   concat->mtd.eccsize != subdev[i]->eccsize) {
> +                   concat->mtd.eccsize != subdev[i]->eccsize ||
> +                   !concat->mtd.read_ecc != !concat->mtd.read_ecc ||
> +                   !concat->mtd.write_ecc != !concat->mtd.write_ecc ||
> +                   !concat->mtd.read_oob != !concat->mtd.read_oob ||
> +                   !concat->mtd.write_oob != !concat->mtd.write_oob) {

Oops. Fixed in CVS.

-- 
dwmw2

WARNING: multiple messages have this Message-ID (diff)
From: David Woodhouse <dwmw2@redhat.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] Fix mtdblock / mtdpart / mtdconcat
Date: Sun, 29 Jun 2003 22:27:25 +0100	[thread overview]
Message-ID: <1056922045.6616.28.camel@lapdancer.baythorne.internal> (raw)
In-Reply-To: <20030629213450.B5653@flint.arm.linux.org.uk>

On Sun, 2003-06-29 at 21:34, Russell King wrote:
> While looking over the changes between 1.5 and 1.6, I spotted this.  You
> may want to fix this change:
> 
> -                   concat->mtd.eccsize != subdev[i]->eccsize) {
> +                   concat->mtd.eccsize != subdev[i]->eccsize ||
> +                   !concat->mtd.read_ecc != !concat->mtd.read_ecc ||
> +                   !concat->mtd.write_ecc != !concat->mtd.write_ecc ||
> +                   !concat->mtd.read_oob != !concat->mtd.read_oob ||
> +                   !concat->mtd.write_oob != !concat->mtd.write_oob) {

Oops. Fixed in CVS.

-- 
dwmw2


  reply	other threads:[~2003-06-29 21:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-23  0:00 [PATCH] Fix mtdblock / mtdpart / mtdconcat Russell King
2003-06-23  7:19 ` David Woodhouse
2003-06-23  7:22   ` Russell King
2003-06-23  7:32     ` David Woodhouse
2003-06-23  8:00       ` Russell King
2003-06-25 12:43 ` David Woodhouse
2003-06-25 12:43   ` David Woodhouse
2003-06-29 20:34   ` Russell King
2003-06-29 20:34     ` Russell King
2003-06-29 21:27     ` David Woodhouse [this message]
2003-06-29 21:27       ` David Woodhouse
2003-06-30  6:08     ` David Woodhouse
2003-06-30  6:08       ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1056922045.6616.28.camel@lapdancer.baythorne.internal \
    --to=dwmw2@redhat.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.