Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Zeno R.R. Davatz]

Hi

I followed your advice and compiled again with the CVS-Version, both i2c and lm-sensors.

Before I done make I done cvs update -d

i2c goes grest but lm-sensors gives me:

kernel/busses/i2c-nforce2.c: In function `nforce2_access':
kernel/busses/i2c-nforce2.c:154: `I2C_CLIENT_PEC' undeclared (first use in this function)
kernel/busses/i2c-nforce2.c:154: (Each undeclared identifier is reported only once
kernel/busses/i2c-nforce2.c:154: for each function it appears in.)
kernel/busses/i2c-nforce2.c:218: `I2C_SMBUS_BLOCK_PROC_CALL' undeclared (first use in this function)
kernel/busses/i2c-nforce2.c:233: `I2C_SMBUS_WORD_DATA_PEC' undeclared (first use in this function)
kernel/busses/i2c-nforce2.c:234: `I2C_SMBUS_BLOCK_DATA_PEC' undeclared (first use in this function)
kernel/busses/i2c-nforce2.c:235: `I2C_SMBUS_PROC_CALL_PEC' undeclared (first use in this function)
kernel/busses/i2c-nforce2.c:236: `I2C_SMBUS_BLOCK_PROC_CALL_PEC' undeclared (first use in this function)
make: *** [kernel/busses/i2c-nforce2.o] Error 1
make: *** Waiting for unfinished jobs....
kernel/busses/i2c-ali1535.c:538: unknown field `owner' specified in initializer
kernel/busses/i2c-ali1535.c:538: warning: missing braces around initializer
kernel/busses/i2c-ali1535.c:538: warning: (near initialization for `ali1535_adapter.name')
kernel/busses/i2c-ali1535.c:538: warning: initialization makes integer from pointer without a cast
kernel/busses/i2c-ali1535.c:538: initializer element is not computable at load time
kernel/busses/i2c-ali1535.c:538: (near initialization for `ali1535_adapter.name[0]')
kernel/busses/i2c-ali1535.c:539: initializer element is not constant
kernel/busses/i2c-ali1535.c:539: (near initialization for `ali1535_adapter.name')
make: *** [kernel/busses/i2c-ali1535.o] Error 1

Any ideas what I am doing wrong or what I could correct in the Makefile?

Thanks for your time and help.

Zeno

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Jean Delvare]

> I followed your advice and compiled again with the CVS-Version, both
> i2c and lm-sensors.
> 
> Before I done make I done cvs update -d
> 
> i2c goes grest but lm-sensors gives me:
> 
> kernel/busses/i2c-nforce2.c: In function `nforce2_access':
> kernel/busses/i2c-nforce2.c:154: `I2C_CLIENT_PEC' undeclared (first
> use in this function) kernel/busses/i2c-nforce2.c:154: (Each
> undeclared identifier is reported only once
> kernel/busses/i2c-nforce2.c:154: for each function it appears in.)
> (...)

CVS is known to compile great, so you must have done a mistake
somewhere, or your system is special (or broken).

Remember you have to *install* i2c before trying to *compile*
lm_sensors2. I would do a fresh CVS checkout and reinstall everything
from scratch, just to make sure no file was accidentally modified in
your local directories.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Zeno R.R. Davatz]

On Thu, 10 Jul 2003 11:51:37 +0200
Jean Delvare <khali@linux-fr.org> wrote:

> OK, I see what's happening. You do have I2C enabled in your current
> kernel, *built-in* (CONFIG_I2C=y), don't you?
> 
> INSTALL says:
> Your I2C support must NOT be built-in your kernel already!
> It must either be disabled or enabled as modules.
> 
> We don't prevent i2c from compiling in this case for very specific
> cases, but it generally won't work, because then lm_sensors has to use
> your kernel i2c headers, which are out of date.
> 
> If I'm right, you'll have to rebuild a kernel with either I2C as a
> module or disabled, and then i2c and lm_sensors will install properly.

Ok, great. Compiled and installed. Thanks!

But now I get the ususal 'no sensors detected'

I tried to force load some ISA/Bus and now sensors-detect gives me a segmentation fault after
whitie:/usr/src/modules/lm_sensors2# sensors-detect
 This program will help you to determine which I2C/SMBus modules you need to
 load to use lm_sensors most effectively.
 You need to have done a `make install', issued a `depmod -a' and made sure
 `/etc/conf.modules' (or `/etc/modules.conf') contains the appropriate
 module path before you can use some functions of this utility. Read
 doc/modules for more information.
 Also, you need to be `root', or at least have access to the /dev/i2c[-/]* files
 for some things. You can use prog/mkdev/mkdev.sh to create these /dev files
 if you do not have them already.
 If you have patched your kernel and have some drivers built-in you can
 safely answer NO if asked to load some modules. In this case, things may
 seem a bit confusing, but they will still work.
 
 BIOS vendor (ACPI): ASUS
 System vendor (DMI): System Manufacturer
 BIOS version (DMI): ASUS PU-DLS/533 ACPI BIOS Revision 1003
 We can start with probing for (PCI) I2C or SMBus adapters.
 You do not need any special privileges for this.
 Do you want to probe now? (YES/no):
Probing for PCI bus adapters...
Sorry, no PCI bus adapters found.
 
 We will now try to load each adapter module in turn.
 Do you now want to be prompted for non-detectable adapters? (yes/NO):
 To continue, we need module `i2c-dev' to be loaded.
 If it is built-in into your kernel, you can safely skip this.
i2c-dev is already loaded.
 
 We are now going to do the adapter probings. Some adapters may hang halfway
 through; we can't really help that. Also, some chips will be double detected;
 we choose the one with the highest confidence value in that case.
 If you found that the adapter hung after probing a certain address, you can
 specify that address to remain unprobed. That often
 includes address 0x69 (clock chip).
Segmentation fault

Any ideas?

Thanks for your Feedback.

Zeno

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Zeno R.R. Davatz]

On Thu, 10 Jul 2003 10:10:47 +0200
Jean Delvare <khali@linux-fr.org> wrote:

> Let's see. Please locate *all* "i2c.h" files that are present on your
> system. Either do:
>   dbupdate
>   locate i2c.h
> or:
>   find / -name "i2c.h"

gives me:
/usr/src/l/linux/linux-2.4.20/arch/cris/drivers/i2c.h
/usr/src/l/linux/linux-2.4.20/include/linux/i2c.h
/usr/src/l/linux/linux-2.4.20/include/config/i2c.h
/usr/src/modules/i2c/kernel/i2c.h
/usr/include/linux/i2c.h

Thanks for your Feedback.

Zeno

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Jean Delvare]

> > Remember you have to *install* i2c before trying to *compile*
> > lm_sensors2. I would do a fresh CVS checkout and reinstall
> > everything from scratch, just to make sure no file was accidentally
> > modified in your local directories.
> Yes I done that. First make and make install in /usr/src/modules/i2c
> and then in /usr/src/lm_sensors2
> 
> I removed all the directories in /usr/src/modules and then done a
> fresh compile. I even done a cvs update -d before I compiled.
> 
> Did I forget anything?

Did you by any chance forgot the "-r lk2-4" when checking i2c out? The
default (HEAD) branch is deprecated and unmaintained, the one that is
known to work is lk2-4. This would explain the errors your get.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Zeno R.R. Davatz]

On Thu, 10 Jul 2003 10:46:23 +0200
Jean Delvare <khali@linux-fr.org> wrote:

> You should have /usr/local/include/linux/i2c.h. That's where i2c (that
> you got from CVS) installs them. So, if you don't have them, either you
> did *not* run "make install" for i2c, or you tweaked the Makefile and
> did not tell us...
> 
> So, what did you really do?
I am very sorry but I just done a fresh checkout of the cvs then make all and make install.

I get: installation successful!

but there is no i2c.h in /usr/local/include/linux

there is one in /usr/include/linux...

the only files I got in /usr/local/include/linux are:
i2c-algo-bit.h  i2c-algo-biths.h  i2c-algo-pcf.h  i2c-dev.h

I did not change anything on the Makefile, also I did not forget to do make install.

Thanks for your Feedback.

Zeno

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Jean Delvare]

> Still get the same error.
> 
> Did I miss anything?

Let's see. Please locate *all* "i2c.h" files that are present on your
system. Either do:
  dbupdate
  locate i2c.h
or:
  find / -name "i2c.h"

And tell me what it returns. Your lm_sensors compilation error shows
that a bad i2c.h file must be picked instead of the new one. If we knew
where it is lurking, we could maybe understand what's going wrong.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Zeno R.R. Davatz]

On Thu, 10 Jul 2003 09:53:48 +0200
Jean Delvare <khali@linux-fr.org> wrote:

> [PLEASE DON'T REPLY TO ME ONLY. REPLY TO THE LIST INSTEAD.]
Ok, sorry.

> Rather logical. Debian is shipping an old (and stable) version of our
> package, which has less devices supported.
Ok.

> Please make sure you uninstall all Debian i2c and lm_sensors packages
> before trying CVS. If you don't, there will be old i2c headers lying
> around and lm_sensors may accidentally get those instead of ours when
> you try to compile it. That too could explain the errors you get.
Ok. I uninstalled i2c-source, lm-sensors-source and lm-sensors

Still get the same error.

Did I miss anything?

Thanks for your Feedback.

Zeno

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Zeno R.R. Davatz]

On Thu, 10 Jul 2003 10:46:23 +0200
Jean Delvare <khali@linux-fr.org> wrote:

> You should have /usr/local/include/linux/i2c.h. That's where i2c (that
> you got from CVS) installs them. So, if you don't have them, either you
> did *not* run "make install" for i2c, or you tweaked the Makefile and
> did not tell us...

I done make install and my include dir is 

LINUX_INCLUDE_DIR := /usr/local/include/linux

I just done make install again and I find no i2c in LINUX_INCLUDE_DIR := /usr/local/include/linux

What I get there is:
i2c-algo-bit.h  i2c-algo-biths.h  i2c-algo-pcf.h  i2c-dev.h

Why whould that be?

Thanks for your Feedback.

Zeno

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Jean Delvare]

> > Let's see. Please locate *all* "i2c.h" files that are present on
> > your system. Either do:
> >   dbupdate
> >   locate i2c.h
> > or:
> >   find / -name "i2c.h"
> 
> gives me:
> /usr/src/l/linux/linux-2.4.20/arch/cris/drivers/i2c.h
> /usr/src/l/linux/linux-2.4.20/include/linux/i2c.h
> /usr/src/l/linux/linux-2.4.20/include/config/i2c.h
> /usr/src/modules/i2c/kernel/i2c.h
> /usr/include/linux/i2c.h

You should have /usr/local/include/linux/i2c.h. That's where i2c (that
you got from CVS) installs them. So, if you don't have them, either you
did *not* run "make install" for i2c, or you tweaked the Makefile and
did not tell us...

So, what did you really do?

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Jean Delvare]

[PLEASE DON'T REPLY TO ME ONLY. REPLY TO THE LIST INSTEAD.]

> Strange enough; If I do it with a Debian package everything install
> great, but no sensors are found. That is why I compile from cvs.
> 
> What else could I have done wrong?

Rather logical. Debian is shipping an old (and stable) version of our
package, which has less devices supported.

Please make sure you uninstall all Debian i2c and lm_sensors packages
before trying CVS. If you don't, there will be old i2c headers lying
around and lm_sensors may accidentally get those instead of ours when
you try to compile it. That too could explain the errors you get.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Zeno R.R. Davatz]

On Thu, 10 Jul 2003 09:37:55 +0200
Jean Delvare <khali@linux-fr.org> wrote:

> Did you by any chance forgot the "-r lk2-4" when checking i2c out? The
> default (HEAD) branch is deprecated and unmaintained, the one that is
> known to work is lk2-4. This would explain the errors your get.

I do:
# cvs -d :pserver:anon@cvs.lm-sensors.nu:/home/cvs login

(Log in using the password, "anonymous".)

# cvs -d :pserver:anon@cvs.lm-sensors.nu:/home/cvs checkout lm_sensors2

# cvs -d :pserver:anon@cvs.lm-sensors.nu:/home/cvs checkout -r lk2-4 i2c

Then I even do cvs update -d

Any hints?

Thanks
Zeno

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Zeno R.R. Davatz]

On Thu, 10 Jul 2003 09:12:55 +0200
Jean Delvare <khali@linux-fr.org> wrote:

> CVS is known to compile great, so you must have done a mistake
> somewhere, or your system is special (or broken).
> 
> Remember you have to *install* i2c before trying to *compile*
> lm_sensors2. I would do a fresh CVS checkout and reinstall everything
> from scratch, just to make sure no file was accidentally modified in
> your local directories.
Yes I done that. First make and make install in /usr/src/modules/i2c and then in /usr/src/lm_sensors2

I removed all the directories in /usr/src/modules and then done a fresh
compile. I even done a cvs update -d before I compiled.

Did I forget anything?

Thanks for your Feedback.

Zeno

Ticket 1319 - lm_sensors-2.8.0-cvs linux-2.4.20-smp-i386

[Jean Delvare]

> > You should have /usr/local/include/linux/i2c.h. That's where i2c
> > (that you got from CVS) installs them. So, if you don't have them,
> > either you did *not* run "make install" for i2c, or you tweaked the
> > Makefile and did not tell us...
> > 
> > So, what did you really do?
> I am very sorry but I just done a fresh checkout of the cvs then make
> all and make install.
> 
> I get: installation successful!
> 
> but there is no i2c.h in /usr/local/include/linux
> 
> there is one in /usr/include/linux...
> 
> the only files I got in /usr/local/include/linux are:
> i2c-algo-bit.h  i2c-algo-biths.h  i2c-algo-pcf.h  i2c-dev.h
> 
> I did not change anything on the Makefile, also I did not forget to do
> make install.

OK, I see what's happening. You do have I2C enabled in your current
kernel, *built-in* (CONFIG_I2C=y), don't you?

INSTALL says:
Your I2C support must NOT be built-in your kernel already!
It must either be disabled or enabled as modules.

We don't prevent i2c from compiling in this case for very specific
cases, but it generally won't work, because then lm_sensors has to use
your kernel i2c headers, which are out of date.

If I'm right, you'll have to rebuild a kernel with either I2C as a
module or disabled, and then i2c and lm_sensors will install properly.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/