All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] remove MULTI_LUN config option
Date: Wed, 3 Sep 2003 04:20:10 +1000	[thread overview]
Message-ID: <20030902182009.GL1941@krispykreme> (raw)
In-Reply-To: <3F5400E6.3000104@pobox.com>


Hi,

> I like the patch, but I worry about the above piece.  I would think that 
> a better patch might make NAC_SCANLUN, LUN_CHECK (tmscsim.c), and 
> similar bits conditional on the module_param you mention?  Ditto for the 
> loops which are now unconditionally executed.  They would still need to 
> be conditional on a runtime variable, right?

Yep, we should be able to use max_scsi_luns to select these things. Im
wondering why these #ifdefs were there in the first place and if it was
the result of a copy from another driver or there really is a need to
do this.

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hi,

> I like the patch, but I worry about the above piece.  I would think that 
> a better patch might make NAC_SCANLUN, LUN_CHECK (tmscsim.c), and 
> similar bits conditional on the module_param you mention?  Ditto for the 
> loops which are now unconditionally executed.  They would still need to 
> be conditional on a runtime variable, right?

Yep, we should be able to use max_scsi_luns to select these things. Im
wondering why these #ifdefs were there in the first place and if it was
the result of a copy from another driver or there really is a need to
do this.

Anton

  reply	other threads:[~2003-09-02 18:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-02  2:11 [PATCH] remove MULTI_LUN config option Anton Blanchard
2003-09-02  2:31 ` Jeff Garzik
2003-09-02 18:20   ` Anton Blanchard [this message]
2003-09-03 21:21 ` Patrick Mansfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030902182009.GL1941@krispykreme \
    --to=anton@samba.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.