From: Jeff Garzik <jgarzik@pobox.com>
To: Anton Blanchard <anton@samba.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] remove MULTI_LUN config option
Date: Mon, 01 Sep 2003 22:31:02 -0400 [thread overview]
Message-ID: <3F5400E6.3000104@pobox.com> (raw)
In-Reply-To: <20030902021145.GC1941@krispykreme>
Anton Blanchard wrote:
> diff -Nru a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
> --- a/drivers/scsi/dc395x.c Tue Sep 2 10:20:06 2003
> +++ b/drivers/scsi/dc395x.c Tue Sep 2 10:20:06 2003
> @@ -633,9 +633,7 @@
> CFG_PARAM_UNSET,
> 0,
> 0x2f,
> -#ifdef CONFIG_SCSI_MULTI_LUN
> NAC_SCANLUN |
> -#endif
> NAC_GT2DRIVES | NAC_GREATER_1G | NAC_POWERON_SCSI_RESET
> /*| NAC_ACTIVE_NEG*/,
> NAC_GT2DRIVES | NAC_GREATER_1G | NAC_POWERON_SCSI_RESET | 0x08
I like the patch, but I worry about the above piece. I would think that
a better patch might make NAC_SCANLUN, LUN_CHECK (tmscsim.c), and
similar bits conditional on the module_param you mention? Ditto for the
loops which are now unconditionally executed. They would still need to
be conditional on a runtime variable, right?
As a tangent, I always build with CONFIG_SCSI_MULTI_LUN=y, so I
definitely support this idea behind this patch...
Jeff
next prev parent reply other threads:[~2003-09-02 2:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-02 2:11 [PATCH] remove MULTI_LUN config option Anton Blanchard
2003-09-02 2:31 ` Jeff Garzik [this message]
2003-09-02 18:20 ` Anton Blanchard
2003-09-03 21:21 ` Patrick Mansfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F5400E6.3000104@pobox.com \
--to=jgarzik@pobox.com \
--cc=anton@samba.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.