All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@brodo.de>
To: cpufreq@www.linux.org.uk, mochel@osdl.org
Subject: Re: cpufreq on ARM - 2.6 problem
Date: Tue, 2 Sep 2003 22:04:51 +0200	[thread overview]
Message-ID: <20030902200451.GA4095@brodo.de> (raw)
In-Reply-To: <20030902182158.C9345@flint.arm.linux.org.uk>

On Tue, Sep 02, 2003 at 06:21:59PM +0100, Russell King wrote:
> Hi,
> 
> There seems to be a problem with cpufreq on SA11x0 platforms when resuming.
> The effect seems to be a hang.  I suspect that this is caused by the cpufreq
> resume method being a sys device (and therefore called with interrupts off).
> It sets the CPU clock rate, which in turn calls the transition notifier,
> which might (and does) sleep.
> 
> (of course, all this happens when the serial console is disabled because
> its a device not a sysdevice, so getting debug out of the system is nigh
> on impossible.)
> 
> I'm not sure what the right way to handle this is, and still ensure that
> all drivers have the right settings for stuff like SDRAM and LCD timings.

[cc'ed Pat for his knowledge of sysdevice handling and of the suspend/resume
process]

AFAICS, the following two things can occur:

	pre-suspend	early during resume
1.)	frequency: A	frequency: A	-- all notifiers, the CPUfreq core, 
					   all drivers think[*] the CPU
					   frequency equals A, it is A, so
					   we don't need to worry about anything.

2.)	frequency: B	frequency: A	-- the CPUfreq core and all
					   (external) drivers think[*] the
					   CPU frequency is equal to B, but
					   it is A. Because of this, the CPU
					   speed must be set AS SOON AS
					   POSSIBLE to B. But as all other
					   pieces of kernel code think it 
					   still equals "B", there is no
					   need to call notifiers. The
					   irqs_disabled() check in
					   cpufreq_notifiy_transition() is
					   triggered and blocks the call to
					   the notifiers.

So, [as long as you use the latest 2.6.0-test4 source] I doubt that it is 
a hang in the cpufreq transition notifiers as they are never even called.

	Dominik

  reply	other threads:[~2003-09-02 20:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-02 17:21 cpufreq on ARM - 2.6 problem Russell King
2003-09-02 20:04 ` Dominik Brodowski [this message]
2003-09-02 22:28   ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030902200451.GA4095@brodo.de \
    --to=linux@brodo.de \
    --cc=cpufreq@www.linux.org.uk \
    --cc=mochel@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.