From: Alistair J Strachan <alistair@devzero.co.uk>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.6.0-test5-mm4
Date: Mon, 22 Sep 2003 15:29:57 +0100 [thread overview]
Message-ID: <200309221529.57836.alistair@devzero.co.uk> (raw)
In-Reply-To: <20030922134813.GF7665@parcelfarce.linux.theplanet.co.uk>
On Monday 22 September 2003 14:48, you wrote:
> On Mon, Sep 22, 2003 at 01:17:42PM +0100, Alistair J Strachan wrote:
> > One possible explanation is that I have devfs compiled into my kernel. I
> > do not, however, have it automatically mounting on boot. It overlays /dev
> > (which is populated with original style device nodes) after INIT has
> > loaded.
>
> Amazingly idiotic typo. And yes, it gets hit only if devfs is configured.
>
> diff -u B5-real32/init/do_mounts.h B5-current/init/do_mounts.h
> --- B5-real32/init/do_mounts.h Sun Sep 21 21:22:33 2003
> +++ B5-current/init/do_mounts.h Mon Sep 22 09:41:21 2003
> @@ -53,7 +53,7 @@
> static inline u32 bstat(char *name)
> {
> struct stat64 stat;
> - if (!sys_stat64(name, &stat) != 0)
> + if (sys_stat64(name, &stat) != 0)
> return 0;
> if (!S_ISBLK(stat.st_mode))
> return 0;
> @@ -65,7 +65,7 @@
> static inline u32 bstat(char *name)
> {
> struct stat stat;
> - if (!sys_newstat(name, &stat) != 0)
> + if (sys_newstat(name, &stat) != 0)
> return 0;
> if (!S_ISBLK(stat.st_mode))
> return 0;
Thanks for that. It's working fine now.
Cheers,
Alistair.
WARNING: multiple messages have this Message-ID (diff)
From: Alistair J Strachan <alistair@devzero.co.uk>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.6.0-test5-mm4
Date: Mon, 22 Sep 2003 15:29:57 +0100 [thread overview]
Message-ID: <200309221529.57836.alistair@devzero.co.uk> (raw)
In-Reply-To: <20030922134813.GF7665@parcelfarce.linux.theplanet.co.uk>
On Monday 22 September 2003 14:48, you wrote:
> On Mon, Sep 22, 2003 at 01:17:42PM +0100, Alistair J Strachan wrote:
> > One possible explanation is that I have devfs compiled into my kernel. I
> > do not, however, have it automatically mounting on boot. It overlays /dev
> > (which is populated with original style device nodes) after INIT has
> > loaded.
>
> Amazingly idiotic typo. And yes, it gets hit only if devfs is configured.
>
> diff -u B5-real32/init/do_mounts.h B5-current/init/do_mounts.h
> --- B5-real32/init/do_mounts.h Sun Sep 21 21:22:33 2003
> +++ B5-current/init/do_mounts.h Mon Sep 22 09:41:21 2003
> @@ -53,7 +53,7 @@
> static inline u32 bstat(char *name)
> {
> struct stat64 stat;
> - if (!sys_stat64(name, &stat) != 0)
> + if (sys_stat64(name, &stat) != 0)
> return 0;
> if (!S_ISBLK(stat.st_mode))
> return 0;
> @@ -65,7 +65,7 @@
> static inline u32 bstat(char *name)
> {
> struct stat stat;
> - if (!sys_newstat(name, &stat) != 0)
> + if (sys_newstat(name, &stat) != 0)
> return 0;
> if (!S_ISBLK(stat.st_mode))
> return 0;
Thanks for that. It's working fine now.
Cheers,
Alistair.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-09-22 14:30 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-22 8:35 2.6.0-test5-mm4 Andrew Morton
2003-09-22 8:35 ` 2.6.0-test5-mm4 Andrew Morton
2003-09-22 11:49 ` 2.6.0-test5-mm4: BeFS compile error Adrian Bunk
2003-09-22 17:57 ` Will Dyson
2003-09-22 12:09 ` 2.6.0-test5-mm4 Florian Schanda
2003-09-22 12:09 ` 2.6.0-test5-mm4 Florian Schanda
2003-09-22 12:17 ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 12:17 ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 13:48 ` 2.6.0-test5-mm4 viro
2003-09-22 13:48 ` 2.6.0-test5-mm4 viro
2003-09-22 14:29 ` Alistair J Strachan [this message]
2003-09-22 14:29 ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 14:30 ` 2.6.0-test5-mm4 Florian Schanda
2003-09-22 14:30 ` 2.6.0-test5-mm4 Florian Schanda
2003-09-22 14:36 ` 2.6.0-test5-mm4 Zilvinas Valinskas
2003-09-22 14:36 ` 2.6.0-test5-mm4 Zilvinas Valinskas
2003-09-22 13:49 ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 13:49 ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 13:54 ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 13:54 ` 2.6.0-test5-mm4 Alistair J Strachan
2003-09-22 18:55 ` 2.6.0-test5-mm4 Andrew Morton
2003-09-22 18:55 ` 2.6.0-test5-mm4 Andrew Morton
2003-09-22 21:27 ` 2.6.0-test5-mm4 Peter Osterlund
2003-09-22 21:27 ` 2.6.0-test5-mm4 Peter Osterlund
2003-09-22 21:45 ` 2.6.0-test5-mm4 Vojtech Pavlik
2003-09-22 21:45 ` 2.6.0-test5-mm4 Vojtech Pavlik
2003-09-25 0:13 ` 2.6.0-test5-mm4 Peter Osterlund
2003-09-25 0:13 ` 2.6.0-test5-mm4 Peter Osterlund
2003-09-25 12:43 ` 2.6.0-test5-mm4 Vojtech Pavlik
2003-09-25 12:43 ` 2.6.0-test5-mm4 Vojtech Pavlik
2003-09-22 21:44 ` 2.6.0-test5-mm4 Vojtech Pavlik
2003-09-22 21:44 ` 2.6.0-test5-mm4 Vojtech Pavlik
2003-09-22 19:10 ` 2.6.0-test5-mm4: wanxl doesn't compile with gcc 2.95 Adrian Bunk
2003-09-22 19:22 ` Andrew Morton
2003-09-22 22:42 ` Krzysztof Halasa
2003-09-22 22:41 ` Andrew Morton
2003-09-23 13:24 ` Krzysztof Halasa
2003-09-24 9:18 ` 2.6.0-test5-mm4 boot crash Helge Hafting
2003-09-24 9:18 ` Helge Hafting
2003-09-24 9:57 ` viro
2003-09-24 9:57 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200309221529.57836.alistair@devzero.co.uk \
--to=alistair@devzero.co.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.