From: "David S. Miller" <davem@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] softirq_pending()
Date: Tue, 23 Sep 2003 10:58:41 -0700 [thread overview]
Message-ID: <20030923105841.27809d11.davem@redhat.com> (raw)
In-Reply-To: <20030923144847.GA16139@lst.de>
On Tue, 23 Sep 2003 16:48:47 +0200
Christoph Hellwig <hch@lst.de> wrote:
> x86-64 currently ignores the cpu argument to softirq_pending() and
> always uses smp_processor_id(). And indeed that's the only possible
> argument. So consolidate the old softirq_pending() and
> local_softirq_pending() into a single one.
The problem is that, on some of the platforms that don't ignore
the argument, the code generation is much better.
GCC doesn't consider smp_processor_id() like some const local
variable, so multiple invocations are assumed to return different
values because in many cases 'current_thread_info()' is obscured.
Your patch is going to make a lot of new code get generated on
x86 for example, so I don't think it should be applied even though
my own platforms are not effected by this issue.
next prev parent reply other threads:[~2003-09-23 17:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-23 14:48 [PATCH] softirq_pending() Christoph Hellwig
2003-09-23 17:58 ` David S. Miller [this message]
2003-09-23 18:06 ` Christoph Hellwig
2003-09-23 18:07 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030923105841.27809d11.davem@redhat.com \
--to=davem@redhat.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.