From: Linus Torvalds <torvalds@osdl.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] softirq_pending()
Date: Tue, 23 Sep 2003 11:07:17 -0700 [thread overview]
Message-ID: <bkq24l$g1v$1@build.pdx.osdl.net> (raw)
In-Reply-To: 20030923144847.GA16139@lst.de
Christoph Hellwig wrote:
> x86-64 currently ignores the cpu argument to softirq_pending() and
> always uses smp_processor_id(). And indeed that's the only possible
> argument. So consolidate the old softirq_pending() and
> local_softirq_pending() into a single one.
The issue is that on some architectures it is quite possibly useful to get
the cpu number, if we end up having to compute it anyway. An example of
this is x86.
On the other hand, some architectures have direct pointers to the "local cpu
state", so for them it is better to always know "this is local" (which it
indeed always is).
So think of the "cpu" argument as a pre-computed "what cpu am I on now"
thing. Especially since we often have it available anyway.
Linus
prev parent reply other threads:[~2003-09-24 7:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-23 14:48 [PATCH] softirq_pending() Christoph Hellwig
2003-09-23 17:58 ` David S. Miller
2003-09-23 18:06 ` Christoph Hellwig
2003-09-23 18:07 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='bkq24l$g1v$1@build.pdx.osdl.net' \
--to=torvalds@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.