From: Jens Axboe <axboe@suse.de>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] don't set underflow for REQ_BLOCK_PC
Date: Wed, 24 Sep 2003 14:27:50 +0200 [thread overview]
Message-ID: <20030924122750.GC15415@suse.de> (raw)
In-Reply-To: <20030922125009.A3244@beaverton.ibm.com>
On Mon, Sep 22 2003, Patrick Mansfield wrote:
> I got underflow warnings and failures when sending an INQUIRY page 0x83
> via the SG_IO REQ_BLOCK_PC interface.
>
> The underflow field should only be set if we know for certain the size of
> the data being transfered, so fix this by leaving it at zero for scsi
> REQ_BLOCK_PC cases.
>
> diff -uprN -X /home/patman/dontdiff bl-25/drivers/scsi/sd.c bl-25-sd_underflow-fix/drivers/scsi/sd.c
> --- bl-25/drivers/scsi/sd.c Mon Sep 8 14:50:56 2003
> +++ bl-25-sd_underflow-fix/drivers/scsi/sd.c Tue Sep 16 16:58:14 2003
> @@ -174,7 +174,6 @@ static int sd_init_command(struct scsi_c
> timeout = rq->timeout;
>
> SCpnt->transfersize = rq->data_len;
> - SCpnt->underflow = rq->data_len;
> goto queue;
> }
>
> diff -uprN -X /home/patman/dontdiff bl-25/drivers/scsi/sr.c bl-25-sd_underflow-fix/drivers/scsi/sr.c
> --- bl-25/drivers/scsi/sr.c Mon Sep 8 14:50:56 2003
> +++ bl-25-sd_underflow-fix/drivers/scsi/sr.c Tue Sep 16 16:58:27 2003
> @@ -301,7 +301,6 @@ static int sr_init_command(struct scsi_c
> timeout = rq->timeout;
>
> SCpnt->transfersize = rq->data_len;
> - SCpnt->underflow = rq->data_len;
> goto queue;
> }
Agree, looks fine.
--
Jens Axboe
prev parent reply other threads:[~2003-09-24 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-22 19:50 [PATCH] don't set underflow for REQ_BLOCK_PC Patrick Mansfield
2003-09-24 12:27 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030924122750.GC15415@suse.de \
--to=axboe@suse.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.