From: greg@kroah.com (Greg KH)
To: lm-sensors@vger.kernel.org
Subject: ISA check
Date: Thu, 19 May 2005 06:24:19 +0000 [thread overview]
Message-ID: <20030928004923.GG5084@kroah.com> (raw)
In-Reply-To: <20030927122942.54c4a7cd.khali@linux-fr.org>
On Sat, Sep 27, 2003 at 12:29:42PM +0200, Jean Delvare wrote:
>
> Hi all,
>
> In many (all?) of our i2c-only drivers, we have the following:
>
> #ifdef DEBUG
> if (i2c_is_isa_adapter(adapter)) {
> printk
> ("lm75.o: lm75_detect called for an ISA bus adapter?!?\n");
> return 0;
> }
> #endif
>
> What's the idea? If the ISA addresses list is empty, is there a way we
> could be called for an ISA adapter anyway? And in that case, shouldn't
> we consider that the user knows what he/she's doing?
Good point, that should just be removed entirely.
Care to send me a patch? :)
thanks,
greg k-h
prev parent reply other threads:[~2005-05-19 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 6:24 ISA check Jean Delvare
2005-05-19 6:24 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030928004923.GG5084@kroah.com \
--to=greg@kroah.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.