* ISA check
@ 2005-05-19 6:24 Jean Delvare
2005-05-19 6:24 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
Hi all,
In many (all?) of our i2c-only drivers, we have the following:
#ifdef DEBUG
if (i2c_is_isa_adapter(adapter)) {
printk
("lm75.o: lm75_detect called for an ISA bus adapter?!?\n");
return 0;
}
#endif
What's the idea? If the ISA addresses list is empty, is there a way we
could be called for an ISA adapter anyway? And in that case, shouldn't
we consider that the user knows what he/she's doing?
If the danger is real, then that check shouldn't be ifdef'd.
Thanks.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
^ permalink raw reply [flat|nested] 2+ messages in thread* ISA check
2005-05-19 6:24 ISA check Jean Delvare
@ 2005-05-19 6:24 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
On Sat, Sep 27, 2003 at 12:29:42PM +0200, Jean Delvare wrote:
>
> Hi all,
>
> In many (all?) of our i2c-only drivers, we have the following:
>
> #ifdef DEBUG
> if (i2c_is_isa_adapter(adapter)) {
> printk
> ("lm75.o: lm75_detect called for an ISA bus adapter?!?\n");
> return 0;
> }
> #endif
>
> What's the idea? If the ISA addresses list is empty, is there a way we
> could be called for an ISA adapter anyway? And in that case, shouldn't
> we consider that the user knows what he/she's doing?
Good point, that should just be removed entirely.
Care to send me a patch? :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-19 6:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-19 6:24 ISA check Jean Delvare
2005-05-19 6:24 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.