Keyboard broken on iBook - linuxppc-2.5 latest

Keyboard broken on iBook - linuxppc-2.5 latest

[cliff white]

Symptoms are identical to those reported on Bugzilla Bug #1025

Kernel: lastest from ppc.bkbits.net/linuxppc-2.5
(10/06/03 AM)

Single keypress produces > 2 repeated characters. Can't even login to
the system, as i cannot enter my uid.

Last successful kernel was from this changeset:

ChangeSet@1.1065, 2003-09-26 22:33:42+10:00, paulus@samba.org

Everything since then either doesn't complie, or has the keyboard problem

Further information on request. Please email me directly as i am not on this list.

cliffw

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Keyboard broken on iBook - linuxppc-2.5 latest

[Benjamin Herrenschmidt]

On Mon, 2003-10-06 at 21:58, cliff white wrote:
> Symptoms are identical to those reported on Bugzilla Bug #1025
>
> Kernel: lastest from ppc.bkbits.net/linuxppc-2.5
> (10/06/03 AM)

Fixed in my tree, I'll send to Linus this week hopefully, after
-test7 is released

Ben.


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Keyboard broken on iBook - linuxppc-2.5 latest

[cliff white]

On Mon, 06 Oct 2003 22:13:12 +0200
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> On Mon, 2003-10-06 at 21:58, cliff white wrote:
> > Symptoms are identical to those reported on Bugzilla Bug #1025
> >
> > Kernel: lastest from ppc.bkbits.net/linuxppc-2.5
> > (10/06/03 AM)
>
> Fixed in my tree, I'll send to Linus this week hopefully, after
> -test7 is released
>
> Ben.
>
>

Thanks, much appreciated. If you'd like some more testing before that,
please point me to bits, would be grateful.

cliffw

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Keyboard broken on iBook - linuxppc-2.5 latest

[Benjamin Herrenschmidt]

On Mon, 2003-10-06 at 22:24, cliff white wrote:

> Thanks, much appreciated. If you'd like some more testing before that,
> please point me to bits, would be grateful.

Patch from Brice Figureau earlier on this list:


     From:
Brice
Figureau
<brice@tincell.com>
       To:
cliff white
<cliffw@osdl.org>
       Cc:
linuxppc-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org
  Subject:
[PATCH]
macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook)
     Date:
Fri, 03 Oct
2003
09:40:22
+0200


Hi Cliff,

On Tue, 2003-09-30 at 23:31, cliff white wrote:
> Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
>
> Symptom: keyboard diarrhea - single keypress == 3-7 characters.

Here is a patch that fixes the keyboard problem. The input layer
REP_DELAY (and REP_PERIOD) were changed from jiffies to ms but the adb
was not updated accordingly.

I hope this will help you.

Brice

--- drivers/macintosh/adbhid.c.orig     2003-10-02 22:39:31.112571794
+0200
+++ drivers/macintosh/adbhid.c  2003-10-02 22:40:22.888120863 +0200
@@ -611,8 +611,8 @@
                /* HACK WARNING!! This should go away as soon there is
an utility
                 * to control that for event devices.
                 */
-               adbhid[id]->input.rep[REP_DELAY] = HZ/2;   /* input
layer default: HZ/4 */
-               adbhid[id]->input.rep[REP_PERIOD] = HZ/15; /* input
layer default: HZ/33 */
+               adbhid[id]->input.rep[REP_DELAY] = 500;   /* input layer
default: 250 */
+               adbhid[id]->input.rep[REP_PERIOD] = 66;   /* input layer
default:  33 */
        }
 }


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Keyboard broken on iBook - linuxppc-2.5 latest

[cliff white]

On Mon, 06 Oct 2003 22:27:28 +0200
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> On Mon, 2003-10-06 at 22:24, cliff white wrote:
>
> > Thanks, much appreciated. If you'd like some more testing before that,
> > please point me to bits, would be grateful.
>
> Patch from Brice Figureau earlier on this list:
>
Thank you all, this does fix my problems
cliffw


>
>      From:
> Brice
> Figureau
> <brice@tincell.com>
>        To:
> cliff white
> <cliffw@osdl.org>
>        Cc:
> linuxppc-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org
>   Subject:
> [PATCH]
> macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook)
>      Date:
> Fri, 03 Oct
> 2003
> 09:40:22
> +0200
>
>
> Hi Cliff,
>
> On Tue, 2003-09-30 at 23:31, cliff white wrote:
> > Kernel version: latest from ppc.bkbits.net/linuxppc-2.5
> >
> > Symptom: keyboard diarrhea - single keypress == 3-7 characters.
>
> Here is a patch that fixes the keyboard problem. The input layer
> REP_DELAY (and REP_PERIOD) were changed from jiffies to ms but the adb
> was not updated accordingly.
>
> I hope this will help you.
>
> Brice
>
> --- drivers/macintosh/adbhid.c.orig     2003-10-02 22:39:31.112571794
> +0200
> +++ drivers/macintosh/adbhid.c  2003-10-02 22:40:22.888120863 +0200
> @@ -611,8 +611,8 @@
>                 /* HACK WARNING!! This should go away as soon there is
> an utility
>                  * to control that for event devices.
>                  */
> -               adbhid[id]->input.rep[REP_DELAY] = HZ/2;   /* input
> layer default: HZ/4 */
> -               adbhid[id]->input.rep[REP_PERIOD] = HZ/15; /* input
> layer default: HZ/33 */
> +               adbhid[id]->input.rep[REP_DELAY] = 500;   /* input layer
> default: 250 */
> +               adbhid[id]->input.rep[REP_PERIOD] = 66;   /* input layer
> default:  33 */
>         }
>  }
>
>
>
>

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/