* [Fwd: sensors, kernel 2.4.19, bttv ...]
2005-05-19 6:24 [Fwd: sensors, kernel 2.4.19, bttv ...] Pascal Ronecker
@ 2005-05-19 6:24 ` Pascal Ronecker
2005-05-19 6:24 ` Jean Delvare
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Pascal Ronecker @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
On Sun, 2003-10-26 at 19:34, Jean Delvare wrote:
> > It's me again... i just would like to add a word : I've just read i2c
> > 2.8.0 was included in kernels after 2.4.21.
>
> No, it isn't. Where did you read that? It might be that *distributions*
> patch the 2.4.21 kernels they are packaging with i2c 2.8.0, but it isn't
> part of the vanilla sources.
>
oo-oops, I misunderstood something i read in the lm_sensors README :
"This lm_sensors release REQUIRES i2c-2.8.0 or later, which is not in
kernels through 2.4.21."
I'm sorry, i understood that as "after 2.4.21 it's okay". I thought i
was better at reading english, still have to enhance it seems :-))
(di dyou notice the ".fr" of my email ;-p)
> > Does it mean that simply upgrading my kernel from 2.4.19 to - say -
> > 2.4.22 will do the trick ?
>
> No, it won't.
>
> > I mean, then I'll only have to compile lm_sensors and everything will
> > be fine (bttv and i2c sensors ?)
>
> You're invited to point your browser to:
> http://www.ensicaen.ismra.fr/~delvare/devel/i2c/
> and read carefully everything that is written there. You'll find the
> patches you need to be able to use i2c-2.8.x and still have bttv
> working. Basically, all you'll have to do is patch your kernel sources
> using one of the provided patches (i2c 2.8.0 for Linux 2.4.21 or i2c
> 2.8.1 for Linux 2.4.22), then installing lm_sensors (same version as
> i2c) will be done as usual.
>
> Let us know how it work for you.
I used the mkpatch.pl script to prepare a i2c patch for my kernel (the
"option 3" installation from the guide.
the kernel compiles fine, then lm_sensors compiles also.
A serious problem remains with bttv module that does not compile.
According to the insructions I read from the adress you gave me, i have
to patch th bttv-if.c file. But the patch doesn't apply, I tried
manually but I do not understand it well enough.
Could you just help me with that ? (it is a small patch, manually
editing should do it)
here is the patch :
diff --exclude=media -ru bttv-0.9.11-orig/bttv-if.c
bttv-0.9.11-i2c/bttv-if.c
--- bttv-0.9.11-orig/bttv-if.c Wed Jun 25 18:26:49 2003
+++ bttv-0.9.11-i2c/bttv-if.c Sun Aug 3 15:33:34 2003
@@ -190,7 +190,7 @@
return state;
}
-#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,54)
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2,4,9)
static void bttv_inc_use(struct i2c_adapter *adap)
{
MOD_INC_USE_COUNT;
@@ -243,9 +243,8 @@
};
static struct i2c_adapter bttv_i2c_adap_template = {
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,0)
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,9)
.owner = THIS_MODULE,
- .class = I2C_ADAP_CLASS_TV_ANALOG,
#else
.inc_use = bttv_inc_use,
.dec_use = bttv_dec_use,
and here my corresponding code, really tiny (original vanilla 2.4.19)
static void bttv_inc_use(struct i2c_adapter *adap)
{
MOD_INC_USE_COUNT;
}
static struct i2c_adapter bttv_i2c_adap_template = {
name: "bt848",
id: I2C_HW_B_BT848,
inc_use: bttv_inc_use,
dec_use: bttv_dec_use,
client_register: attach_inform,
client_unregister: detach_inform,
};
what should result of the editing ???
(there are either not enough minus/plus signs, or not enough, i'm
confused again ...)
thank you !
^ permalink raw reply [flat|nested] 7+ messages in thread* [Fwd: sensors, kernel 2.4.19, bttv ...]
2005-05-19 6:24 [Fwd: sensors, kernel 2.4.19, bttv ...] Pascal Ronecker
2005-05-19 6:24 ` Pascal Ronecker
@ 2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Jean Delvare
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Jean Delvare @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
> I used the mkpatch.pl script to prepare a i2c patch for my kernel (the
> "option 3" installation from the guide.
> the kernel compiles fine, then lm_sensors compiles also.
> A serious problem remains with bttv module that does not compile.
> According to the insructions I read from the adress you gave me, i
> have to patch th bttv-if.c file. But the patch doesn't apply, I tried
> manually but I do not understand it well enough.
>
> Could you just help me with that ?
Sure. Anyway, the easiest way to get everything working would be to
upgrade your kernel up to 2.4.22 and use my all-in-one, ready-to-apply
patch.
> here is the patch :
>
> diff --exclude=media -ru bttv-0.9.11-orig/bttv-if.c
> bttv-0.9.11-i2c/bttv-if.c
> --- bttv-0.9.11-orig/bttv-if.c Wed Jun 25 18:26:49 2003
> +++ bttv-0.9.11-i2c/bttv-if.c Sun Aug 3 15:33:34 2003
> (...)
> and here my corresponding code, really tiny (original vanilla 2.4.19)
You're trying to do the wrong thing. This patch is intended for people
using recent bttv sources from outside the kernel. If you are using the
bttv driver from the Linux kernel, then you should use this one:
http://www.ensicaen.ismra.fr/~delvare/devel/i2c/linux-2.4.22/linux-2.4.22-i2c-2.8.1-drivers-media-video.diff
or, if you are using i2c 2.8.0:
http://www.ensicaen.ismra.fr/~delvare/devel/i2c/linux-2.4.21/linux-2.4.21-i2c-2.8.0-drivers-media-video.diff
That will fix all video drivers in your kernel tree, including bttv.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
^ permalink raw reply [flat|nested] 7+ messages in thread* [Fwd: sensors, kernel 2.4.19, bttv ...]
2005-05-19 6:24 [Fwd: sensors, kernel 2.4.19, bttv ...] Pascal Ronecker
2005-05-19 6:24 ` Pascal Ronecker
2005-05-19 6:24 ` Jean Delvare
@ 2005-05-19 6:24 ` Jean Delvare
2005-05-19 6:24 ` Pascal Ronecker
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Jean Delvare @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
> It's me again... i just would like to add a word : I've just read i2c
> 2.8.0 was included in kernels after 2.4.21.
No, it isn't. Where did you read that? It might be that *distributions*
patch the 2.4.21 kernels they are packaging with i2c 2.8.0, but it isn't
part of the vanilla sources.
> Does it mean that simply upgrading my kernel from 2.4.19 to - say -
> 2.4.22 will do the trick ?
No, it won't.
> I mean, then I'll only have to compile lm_sensors and everything will
> be fine (bttv and i2c sensors ?)
You're invited to point your browser to:
http://www.ensicaen.ismra.fr/~delvare/devel/i2c/
and read carefully everything that is written there. You'll find the
patches you need to be able to use i2c-2.8.x and still have bttv
working. Basically, all you'll have to do is patch your kernel sources
using one of the provided patches (i2c 2.8.0 for Linux 2.4.21 or i2c
2.8.1 for Linux 2.4.22), then installing lm_sensors (same version as
i2c) will be done as usual.
Let us know how it work for you.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
^ permalink raw reply [flat|nested] 7+ messages in thread* [Fwd: sensors, kernel 2.4.19, bttv ...]
2005-05-19 6:24 [Fwd: sensors, kernel 2.4.19, bttv ...] Pascal Ronecker
` (2 preceding siblings ...)
2005-05-19 6:24 ` Jean Delvare
@ 2005-05-19 6:24 ` Pascal Ronecker
2005-05-19 6:24 ` Pascal Ronecker
2005-05-19 6:24 ` Jean Delvare
5 siblings, 0 replies; 7+ messages in thread
From: Pascal Ronecker @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
You're right : it is done, and it works !
Thanks for all,
I only have a few tweaks to do with the new kernel (udma support seem
lazy, I missed a step somwhere as usually, but that's another short
story :-) )
On Mon, 2003-10-27 at 22:10, Jean Delvare wrote:
> > I'll finally upgrade to 2.4.22 kernel, to use the provided patch.
> > But before doing that - as it is not that quick (recompiling nvidia
> > drivers, alsa drivers, and what more?) : i'm using also lirc... and it
> > seems that it requires also a patch. Will it be that complicated ?
>
> There is a specific patch for lirc, that you'll find on the very same
> page as the main patch. Both 0.6.6 and CVS versions are supported. So,
> no, it shouldn't be difficult at all.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Fwd: sensors, kernel 2.4.19, bttv ...]
2005-05-19 6:24 [Fwd: sensors, kernel 2.4.19, bttv ...] Pascal Ronecker
` (3 preceding siblings ...)
2005-05-19 6:24 ` Pascal Ronecker
@ 2005-05-19 6:24 ` Pascal Ronecker
2005-05-19 6:24 ` Jean Delvare
5 siblings, 0 replies; 7+ messages in thread
From: Pascal Ronecker @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
Je viens de voir le .fr de ta propre adresse, donc je me permets de
faire dans le bilingue.
Finalement je pense bien upgrader au 2.4.22 et prendre le patch unique,
ca devrait m'?viter des d?boires. Sauf que j'utilise aussi lirc, et si
j'en crois ce que j'ai lu, ca me promet aussi de ne pas ?tre triste. ...
Alors avant de m'y jeter (et au passage devoir aussi reinstaller mes
drivers video nvidia et sons alsa, a chaque fois la grande joie, plus ce
que j'oublie) ... quelle gal?re je risque avec lirc ?
---------------------------------
Now in english for the .com e-mail
I'll finally upgrade to 2.4.22 kernel, to use the provided patch.
But before doing that - as it is not that quick (recompiling nvidia
drivers, alsa drivers, and what more?) : i'm using also lirc... and it
seems that it requires also a patch. Will it be that complicated ?
thx anyway !
On Sun, 2003-10-26 at 21:58, Jean Delvare wrote:
> > I used the mkpatch.pl script to prepare a i2c patch for my kernel (the
> > "option 3" installation from the guide.
> > the kernel compiles fine, then lm_sensors compiles also.
> > A serious problem remains with bttv module that does not compile.
> > According to the insructions I read from the adress you gave me, i
> > have to patch th bttv-if.c file. But the patch doesn't apply, I tried
> > manually but I do not understand it well enough.
> >
> > Could you just help me with that ?
>
> Sure. Anyway, the easiest way to get everything working would be to
> upgrade your kernel up to 2.4.22 and use my all-in-one, ready-to-apply
> patch.
>
> > here is the patch :
> >
> > diff --exclude=media -ru bttv-0.9.11-orig/bttv-if.c
> > bttv-0.9.11-i2c/bttv-if.c
> > --- bttv-0.9.11-orig/bttv-if.c Wed Jun 25 18:26:49 2003
> > +++ bttv-0.9.11-i2c/bttv-if.c Sun Aug 3 15:33:34 2003
> > (...)
> > and here my corresponding code, really tiny (original vanilla 2.4.19)
>
> You're trying to do the wrong thing. This patch is intended for people
> using recent bttv sources from outside the kernel. If you are using the
> bttv driver from the Linux kernel, then you should use this one:
> http://www.ensicaen.ismra.fr/~delvare/devel/i2c/linux-2.4.22/linux-2.4.22-i2c-2.8.1-drivers-media-video.diff
> or, if you are using i2c 2.8.0:
> http://www.ensicaen.ismra.fr/~delvare/devel/i2c/linux-2.4.21/linux-2.4.21-i2c-2.8.0-drivers-media-video.diff
>
> That will fix all video drivers in your kernel tree, including bttv.
^ permalink raw reply [flat|nested] 7+ messages in thread* [Fwd: sensors, kernel 2.4.19, bttv ...]
2005-05-19 6:24 [Fwd: sensors, kernel 2.4.19, bttv ...] Pascal Ronecker
` (4 preceding siblings ...)
2005-05-19 6:24 ` Pascal Ronecker
@ 2005-05-19 6:24 ` Jean Delvare
5 siblings, 0 replies; 7+ messages in thread
From: Jean Delvare @ 2005-05-19 6:24 UTC (permalink / raw)
To: lm-sensors
> I'll finally upgrade to 2.4.22 kernel, to use the provided patch.
> But before doing that - as it is not that quick (recompiling nvidia
> drivers, alsa drivers, and what more?) : i'm using also lirc... and it
> seems that it requires also a patch. Will it be that complicated ?
There is a specific patch for lirc, that you'll find on the very same
page as the main patch. Both 0.6.6 and CVS versions are supported. So,
no, it shouldn't be difficult at all.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
^ permalink raw reply [flat|nested] 7+ messages in thread