From: Russell King <rmk@arm.linux.org.uk>
To: Ducrot Bruno <ducrot@arm.linux.org.uk>
Cc: cpufreq@lists.arm.linux.org.uk
Subject: Re: cpufreq/linux/arch/arm/mach-sa1100 cpu-sa1100.c, 1.4, 1.5 cpu-sa1110.c, 1.10, 1.11
Date: Wed, 5 Nov 2003 20:13:14 +0000 [thread overview]
Message-ID: <20031105201314.A2986@flint.arm.linux.org.uk> (raw)
In-Reply-To: <E1AHSO6-0000Zc-U1@flint.arm.linux.org.uk>; from ducrot@arm.linux.org.uk on Wed, Nov 05, 2003 at 06:28:14PM +0000
On Wed, Nov 05, 2003 at 06:28:14PM +0000, Ducrot Bruno wrote:
> --- cpu-sa1110.c 19 Aug 2003 13:38:32 -0000 1.10
> +++ cpu-sa1110.c 5 Nov 2003 18:27:41 -0000 1.11
> @@ -270,8 +270,12 @@
> * We wait 20ms to be safe.
> */
> sdram_set_refresh(2);
> + if (!irqs_disabled()) {
> set_current_state(TASK_UNINTERRUPTIBLE);
> schedule_timeout(20 * HZ / 1000);
> + } else {
> + mdelay(20);
> + }
Hmm, this doesn't look right. Did you apply a patch generated by ignoring
space changes, 'cause this doesn't reflect what is actually in Linus tree,
which is:
if (!irqs_disabled()) {
set_current_state(TASK_UNINTERRUPTIBLE);
schedule_timeout(20 * HZ / 1000);
} else {
mdelay(20);
}
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
prev parent reply other threads:[~2003-11-05 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-05 18:28 cpufreq/linux/arch/arm/mach-sa1100 cpu-sa1100.c, 1.4, 1.5 cpu-sa1110.c, 1.10, 1.11 Ducrot Bruno
2003-11-05 20:13 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031105201314.A2986@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=cpufreq@lists.arm.linux.org.uk \
--cc=ducrot@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.