All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@brodo.de>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: cpufreq@www.linux.org.uk
Subject: Re: Implementation of fast-up algorithm in ondemand governor
Date: Thu, 6 Nov 2003 07:50:00 +0100	[thread overview]
Message-ID: <20031106065000.GA4188@brodo.de> (raw)
In-Reply-To: <CFF522B18982EA4481D3A3E23B83141C24B53F@orsmsx407.jf.intel.com>

On Wed, Nov 05, 2003 at 02:34:07PM -0800, Moore, Robert wrote:
> 
> 
> Will this simple change implement the fast-up algorithm correctly?

"the" fast-up algorithm? Well, it surely _is_ a fast-up algorithm what you
propose:


> -	if (idle_ticks < (DBS_RATE / 5))
> -		cpufreq_driver_target(cpu_dbs_info[cpu].cur_policy,
> -			cpu_dbs_info[cpu].cur_policy->cur + 1, 
> -			CPUFREQ_RELATION_L);
> 
> +	if (idle_ticks < (DBS_RATE / 5))
> +		cpufreq_driver_target(cpu_dbs_info[cpu].cur_policy,
> +			cpu_dbs_info[cpu].cur_policy->max, 
> +			CPUFREQ_RELATION_L);		

However, please set CPUFREQ_RELATION_H here -- you don't want to go higher
than cur_policy->max.

	Dominik

      reply	other threads:[~2003-11-06  6:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-05 22:34 Implementation of fast-up algorithm in ondemand governor Moore, Robert
2003-11-06  6:50 ` Dominik Brodowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031106065000.GA4188@brodo.de \
    --to=linux@brodo.de \
    --cc=cpufreq@www.linux.org.uk \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.