All of lore.kernel.org
 help / color / mirror / Atom feed
* Implementation of fast-up algorithm in ondemand governor
@ 2003-11-05 22:34 Moore, Robert
  2003-11-06  6:50 ` Dominik Brodowski
  0 siblings, 1 reply; 2+ messages in thread
From: Moore, Robert @ 2003-11-05 22:34 UTC (permalink / raw)
  To: Dominik Brodowski, cpufreq



Will this simple change implement the fast-up algorithm correctly?


-	if (idle_ticks < (DBS_RATE / 5))
-		cpufreq_driver_target(cpu_dbs_info[cpu].cur_policy,
-			cpu_dbs_info[cpu].cur_policy->cur + 1, 
-			CPUFREQ_RELATION_L);

+	if (idle_ticks < (DBS_RATE / 5))
+		cpufreq_driver_target(cpu_dbs_info[cpu].cur_policy,
+			cpu_dbs_info[cpu].cur_policy->max, 
+			CPUFREQ_RELATION_L);		

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Implementation of fast-up algorithm in ondemand governor
  2003-11-05 22:34 Implementation of fast-up algorithm in ondemand governor Moore, Robert
@ 2003-11-06  6:50 ` Dominik Brodowski
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Brodowski @ 2003-11-06  6:50 UTC (permalink / raw)
  To: Moore, Robert; +Cc: cpufreq

On Wed, Nov 05, 2003 at 02:34:07PM -0800, Moore, Robert wrote:
> 
> 
> Will this simple change implement the fast-up algorithm correctly?

"the" fast-up algorithm? Well, it surely _is_ a fast-up algorithm what you
propose:


> -	if (idle_ticks < (DBS_RATE / 5))
> -		cpufreq_driver_target(cpu_dbs_info[cpu].cur_policy,
> -			cpu_dbs_info[cpu].cur_policy->cur + 1, 
> -			CPUFREQ_RELATION_L);
> 
> +	if (idle_ticks < (DBS_RATE / 5))
> +		cpufreq_driver_target(cpu_dbs_info[cpu].cur_policy,
> +			cpu_dbs_info[cpu].cur_policy->max, 
> +			CPUFREQ_RELATION_L);		

However, please set CPUFREQ_RELATION_H here -- you don't want to go higher
than cur_policy->max.

	Dominik

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-11-06  6:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-05 22:34 Implementation of fast-up algorithm in ondemand governor Moore, Robert
2003-11-06  6:50 ` Dominik Brodowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.