All of lore.kernel.org
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: Maneesh Soni <maneesh@in.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Patrick Mochel <mochel@osdl.org>, Andrew Morton <akpm@osdl.org>,
	Dipankar Sarma <dipankar@in.ibm.com>
Subject: Re: [PATCH] sysfs_remove_dir Vs dcache_readdir race fix
Date: Thu, 20 Nov 2003 05:49:57 +0000	[thread overview]
Message-ID: <20031120054957.GD24159@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20031120054707.GA1724@in.ibm.com>

On Thu, Nov 20, 2003 at 11:17:07AM +0530, Maneesh Soni wrote:
> Hi,
> 
> sysfs_remove_dir modifies d_subdirs list which results in inconsistency
> when there is concurrent dcache_readdir is going on. I think there
> is no need for sysfs_remove_dir to modify d_subdirs list and removal
> of dentries from d_child list is taken care in the final dput().

WTF?

All instances of ->readdir() are protected by ->i_sem on parent.  So
are all operations in sysfs_remove_dir().

Have you actually observed any race there?

  reply	other threads:[~2003-11-20  5:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-20  5:47 [PATCH] sysfs_remove_dir Vs dcache_readdir race fix Maneesh Soni
2003-11-20  5:49 ` viro [this message]
2003-11-20  5:56   ` Maneesh Soni
2003-11-20 10:25     ` Maneesh Soni
2003-11-20 15:17       ` Andrew Morton
2003-11-20 16:40         ` Dipankar Sarma
2003-11-20 18:44         ` viro
2003-11-20 18:43       ` viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031120054957.GD24159@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=akpm@osdl.org \
    --cc=dipankar@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maneesh@in.ibm.com \
    --cc=mochel@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.