From: jbarnes@sgi.com (Jesse Barnes)
To: Andrew Morton <akpm@osdl.org>,
colpatch@us.ibm.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mbligh@aracnet.com
Subject: Re: [RFC] Simplify node/zone portion of page->flags
Date: Mon, 24 Nov 2003 15:31:55 -0800 [thread overview]
Message-ID: <20031124233155.GA27541@sgi.com> (raw)
In-Reply-To: <20031123224903.GB21617@sgi.com>
On Sun, Nov 23, 2003 at 02:49:03PM -0800, Jesse Barnes wrote:
> On Sun, Nov 23, 2003 at 02:40:52PM -0800, Andrew Morton wrote:
> > > zone_num. This makes it trivial to recover either the node or zone
> > > number with a simple bitshift. There are many places in the kernel
> > > where we do things like: page_zone(page)->zone_pgdat->node_id to
> > > determine the node a page belongs to. With this patch we save several
> > > pointer dereferences, and it boils down to shifting some bits.
> >
> > This rather conflicts with the patch from Jesse which I have. Can you guys
> > work that out and let me know when you're done?
>
> I like Matt's patch, but haven't tested it yet. I'll try it out on
> Monday.
Matt, this looks ok (at least it boots on my test system). I wasn't
able test it on a very large system though, but it looks functionally
identical to the patch in Andrew's tree. Btw, you probably want to put
() around NODEZONE_SHIFT + ZONES_SHIFT in page_nodenum() otherwise gcc
will complain loudly.
Jesse
WARNING: multiple messages have this Message-ID (diff)
From: jbarnes@sgi.com (Jesse Barnes)
To: Andrew Morton <akpm@osdl.org>,
colpatch@us.ibm.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mbligh@aracnet.com
Subject: Re: [RFC] Simplify node/zone portion of page->flags
Date: Mon, 24 Nov 2003 15:31:55 -0800 [thread overview]
Message-ID: <20031124233155.GA27541@sgi.com> (raw)
In-Reply-To: <20031123224903.GB21617@sgi.com>
On Sun, Nov 23, 2003 at 02:49:03PM -0800, Jesse Barnes wrote:
> On Sun, Nov 23, 2003 at 02:40:52PM -0800, Andrew Morton wrote:
> > > zone_num. This makes it trivial to recover either the node or zone
> > > number with a simple bitshift. There are many places in the kernel
> > > where we do things like: page_zone(page)->zone_pgdat->node_id to
> > > determine the node a page belongs to. With this patch we save several
> > > pointer dereferences, and it boils down to shifting some bits.
> >
> > This rather conflicts with the patch from Jesse which I have. Can you guys
> > work that out and let me know when you're done?
>
> I like Matt's patch, but haven't tested it yet. I'll try it out on
> Monday.
Matt, this looks ok (at least it boots on my test system). I wasn't
able test it on a very large system though, but it looks functionally
identical to the patch in Andrew's tree. Btw, you probably want to put
() around NODEZONE_SHIFT + ZONES_SHIFT in page_nodenum() otherwise gcc
will complain loudly.
Jesse
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-11-24 23:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-22 1:14 [RFC] Simplify node/zone portion of page->flags Matthew Dobson
2003-11-23 22:40 ` Andrew Morton
2003-11-23 22:40 ` Andrew Morton
2003-11-23 22:49 ` Jesse Barnes
2003-11-23 22:49 ` Jesse Barnes
2003-11-24 23:31 ` Jesse Barnes [this message]
2003-11-24 23:31 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031124233155.GA27541@sgi.com \
--to=jbarnes@sgi.com \
--cc=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.