All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: ACPI mailing list
	<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	kernel list
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	Rusty trivial patch monkey Russell
	<trivial-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
Subject: Re: Tell user when ACPI is killing machine
Date: Fri, 28 Nov 2003 17:52:46 +0100	[thread overview]
Message-ID: <20031128165246.GA323@elf.ucw.cz> (raw)
In-Reply-To: <20031128145558.GA576-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>

Hi!

> On critical overheat (or perceived critical overheat -- acpi bioses on
> some notebooks apparently report bogus values from time to time),
> kernel itself calls /sbin/halt *without telling anything*. User can
> not see anything, his machine just shuts down cleanly. Bad.
> 
> We should at least tell the user what is going on... 

Okay, I had two bugs in single line of code (%ld and
KELVIN_TO_CELSIUS). Sorry about that, here's better version.

								Pavel

--- clean/drivers/acpi/thermal.c	2003-07-27 22:31:09.000000000 +0200
+++ linux/drivers/acpi/thermal.c	2003-11-28 17:42:17.000000000 +0100
@@ -467,6 +474,7 @@
 	if (result)
 		return_VALUE(result);
 
+	printk(KERN_EMERG "Critical temperature reached (%ld C), shutting down.\n", KELVIN_TO_CELSIUS(tz->temperature));
 	acpi_bus_generate_event(device, ACPI_THERMAL_NOTIFY_CRITICAL, tz->trips.critical.flags.enabled);
 
 	acpi_thermal_call_usermode(ACPI_THERMAL_PATH_POWEROFF);


-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: ACPI mailing list <acpi-devel@lists.sourceforge.net>,
	kernel list <linux-kernel@vger.kernel.org>,
	len.brown@intel.com,
	Rusty trivial patch monkey Russell  <trivial@rustcorp.com.au>
Subject: Re: Tell user when ACPI is killing machine
Date: Fri, 28 Nov 2003 17:52:46 +0100	[thread overview]
Message-ID: <20031128165246.GA323@elf.ucw.cz> (raw)
In-Reply-To: <20031128145558.GA576@elf.ucw.cz>

Hi!

> On critical overheat (or perceived critical overheat -- acpi bioses on
> some notebooks apparently report bogus values from time to time),
> kernel itself calls /sbin/halt *without telling anything*. User can
> not see anything, his machine just shuts down cleanly. Bad.
> 
> We should at least tell the user what is going on... 

Okay, I had two bugs in single line of code (%ld and
KELVIN_TO_CELSIUS). Sorry about that, here's better version.

								Pavel

--- clean/drivers/acpi/thermal.c	2003-07-27 22:31:09.000000000 +0200
+++ linux/drivers/acpi/thermal.c	2003-11-28 17:42:17.000000000 +0100
@@ -467,6 +474,7 @@
 	if (result)
 		return_VALUE(result);
 
+	printk(KERN_EMERG "Critical temperature reached (%ld C), shutting down.\n", KELVIN_TO_CELSIUS(tz->temperature));
 	acpi_bus_generate_event(device, ACPI_THERMAL_NOTIFY_CRITICAL, tz->trips.critical.flags.enabled);
 
 	acpi_thermal_call_usermode(ACPI_THERMAL_PATH_POWEROFF);


-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

  parent reply	other threads:[~2003-11-28 16:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-28 14:55 Tell user when ACPI is killing machine Pavel Machek
     [not found] ` <20031128145558.GA576-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2003-11-28 16:52   ` Pavel Machek [this message]
2003-11-28 16:52     ` Pavel Machek
2003-11-28 17:07 ` Frederik Deweerdt
2003-11-28 22:01 ` Aaron Lehmann
2003-11-28 23:43   ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2003-12-04  5:27 Yu, Luming
2003-12-04  5:27 ` Yu, Luming
     [not found] ` <3ACA40606221794F80A5670F0AF15F8401720BFD-4yWAQGcml64gGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2003-12-04  9:54   ` Pavel Machek
2003-12-04  9:54     ` Pavel Machek
2003-12-04 10:01     ` Damien Sandras
2003-12-04 10:56       ` Pavel Machek
2003-12-04 11:24         ` Måns Rullgård
2003-12-08  3:26 Yu, Luming
2003-12-08  3:26 ` Yu, Luming
     [not found] ` <3ACA40606221794F80A5670F0AF15F8401720C05-SRlDPOYGfgogGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2003-12-09 11:25   ` Pavel Machek
2003-12-09 11:25     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031128165246.GA323@elf.ucw.cz \
    --to=pavel-+zi9xunit7i@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=trivial-8n+1lVoiYb80n/F98K4Iww@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.