All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Goodall <joshua@myinternet.com.au>
To: Patrick McHardy <kaber@trash.net>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: Re: [RFC] updated ctnetlink patches: ctnetlink-0.12.diff
Date: Fri, 5 Dec 2003 13:55:03 +1100	[thread overview]
Message-ID: <20031205025503.GA11243@myinternet.com.au> (raw)
In-Reply-To: <3ED4BD8D.1070500@trash.net>

On Wed, May 28, 2003 at 03:45:49PM +0200, Patrick McHardy wrote:
> # import ctnetlink 0.12 changes
> # --------------------------------------------
[snip]

> diff -Nru a/net/ipv4/netfilter/nfnetlink.c b/net/ipv4/netfilter/nfnetlink.c
> --- /dev/null	Wed Dec 31 16:00:00 1969
> +++ b/net/ipv4/netfilter/nfnetlink.c	Tue May 27 19:26:26 2003
[snip]
> +#define nf_debug(level, format, arg...)					       \
> +	do {								       \
> +		if (nf_debug_level > level)				       \
> +			printk(KERN_DEBUG "%s: " format, __FUNCTION__, ## arg);\
> +	} while(0)

This triggers a bug in GCC 2.95.4 (Debian stable and others) and breaks
the build.

Please use
printk(KERN_DEBUG "%s: " format, __FUNCTION__ , ## arg);
- note the space after __FUNCTION__.

Also occurs later in nfnetlink_conntrack.c.

Thanks!
Joshua.

  reply	other threads:[~2003-12-05  2:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-28 13:45 [RFC] updated ctnetlink patches: ctnetlink-0.12.diff Patrick McHardy
2003-12-05  2:55 ` Joshua Goodall [this message]
2003-12-05  3:01   ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031205025503.GA11243@myinternet.com.au \
    --to=joshua@myinternet.com.au \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.