All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Joshua Goodall <joshua@myinternet.com.au>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: Re: [RFC] updated ctnetlink patches: ctnetlink-0.12.diff
Date: Fri, 05 Dec 2003 04:01:51 +0100	[thread overview]
Message-ID: <3FCFF51F.1050102@trash.net> (raw)
In-Reply-To: <20031205025503.GA11243@myinternet.com.au>

Joshua Goodall wrote:

>>+#define nf_debug(level, format, arg...)					       \
>>+	do {								       \
>>+		if (nf_debug_level > level)				       \
>>+			printk(KERN_DEBUG "%s: " format, __FUNCTION__, ## arg);\
>>+	} while(0)
>>    
>>
>
>This triggers a bug in GCC 2.95.4 (Debian stable and others) and breaks
>the build.
>
>Please use
>printk(KERN_DEBUG "%s: " format, __FUNCTION__ , ## arg);
>- note the space after __FUNCTION__.
>
>Also occurs later in nfnetlink_conntrack.c.
>  
>

I will fix it in the next version which I plan to finish around christmas.

Thanks,
Patrick

      reply	other threads:[~2003-12-05  3:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-28 13:45 [RFC] updated ctnetlink patches: ctnetlink-0.12.diff Patrick McHardy
2003-12-05  2:55 ` Joshua Goodall
2003-12-05  3:01   ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FCFF51F.1050102@trash.net \
    --to=kaber@trash.net \
    --cc=joshua@myinternet.com.au \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.