From: Andi Kleen <ak@suse.de>
To: "Yu, Luming" <luming.yu@intel.com>
Cc: menage@google.com, agrover@groveronline.com,
linux-kernel@vger.kernel.org, acpi-devel@lists.sourceforge.net
Subject: Re: [ACPI] ACPI global lock macros
Date: Thu, 11 Dec 2003 09:07:16 +0100 [thread overview]
Message-ID: <20031211090716.0c3662d3.ak@suse.de> (raw)
In-Reply-To: <3ACA40606221794F80A5670F0AF15F8401720C21@PDSMSX403.ccr.corp.intel.com>
On Thu, 11 Dec 2003 15:06:10 +0800
"Yu, Luming" <luming.yu@intel.com> wrote:
>
> Above code have a bug! Considering below code:
>
> u8 acquired = FALSE;
>
> ACPI_ACQUIRE_GLOBAL_LOC(acpi_gbl_common_fACS.global_lock, acquired);
> if(acquired) {
> ....
> }
>
> Gcc will complain " ERROR: '%cl' not allowed with sbbl ". And I think any other compiler will
> complain that too !
It has even more bugs, e.g. it doesn't tell gcc that GLptr is modified (this hurts with
newer versions that optimize more aggressively)
I tried to fix it on x86-64, but eventually gave up and adopted the IA64 C version.
-Andi
next prev parent reply other threads:[~2003-12-11 8:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-11 7:06 ACPI global lock macros Yu, Luming
2003-12-11 7:06 ` [ACPI] " Yu, Luming
2003-12-11 8:07 ` Andi Kleen [this message]
[not found] ` <20031211090716.0c3662d3.ak-l3A5Bk7waGM@public.gmane.org>
2003-12-11 8:27 ` Paul Menage
2003-12-11 8:27 ` [ACPI] " Paul Menage
[not found] ` <3ACA40606221794F80A5670F0AF15F8401720C21-SRlDPOYGfgogGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2003-12-11 8:20 ` Paul Menage
2003-12-11 8:20 ` [ACPI] " Paul Menage
-- strict thread matches above, loose matches on Subject: below --
2003-12-11 7:27 Yu, Luming
2003-12-11 17:46 ` Nate Lawson
2003-12-09 18:20 Grover, Andrew
2003-12-09 18:20 ` Grover, Andrew
2003-12-09 19:04 ` Paul Menage
2003-12-09 19:03 ` David Mosberger
2003-12-09 9:22 Paul Menage
2003-12-10 7:45 ` [ACPI] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031211090716.0c3662d3.ak@suse.de \
--to=ak@suse.de \
--cc=acpi-devel@lists.sourceforge.net \
--cc=agrover@groveronline.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@intel.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.